Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[-] BO : fix issue with image resize when original is smaller than target #3289

Merged
merged 4 commits into from Jun 26, 2015

Conversation

@jocel1
Copy link
Contributor

commented Jun 26, 2015

No description provided.

jnadaud pushed a commit that referenced this pull request Jun 26, 2015
Jérôme Nadaud
Merge pull request #3289 from jocel1/hotfix-image-resize
[-] BO : fix issue with image resize when original is smaller than target

@jnadaud jnadaud merged commit e14cbc3 into PrestaShop:1.6 Jun 26, 2015

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@jocel1 jocel1 deleted the jocel1:hotfix-image-resize branch Apr 15, 2016

@e-gaulue

This comment has been minimized.

Copy link
Contributor

commented on 7d1e280 May 25, 2016

Hi,

In this patch, you introduced:

Those seems unsued anywhere. Worse, $quality is even not referenced in the fonction.

Is this a (coming) feature? In this case could you add explanation near your declared var or bring me to a nice documentation. If not can I propose to remove them in my next pull?

Regards,

This comment has been minimized.

Copy link
Contributor Author

replied May 25, 2016

Hi,

Those variables are used in the AdminImportController.php in the copyImg function to speed up the import process.

HTH,

This comment has been minimized.

Copy link
Contributor

replied May 25, 2016

OK,

Btw, $quality is used in the function.

I'll add information regarding this in my next patch.

Regards,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.