Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix smarty deprecation #32967

Closed
wants to merge 2 commits into from
Closed

fix smarty deprecation #32967

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
13bc34e
fix smarty deprecation
lmeyer1 Jun 21, 2023
22c8ff0
fix smarty deprecation
lmeyer1 Jun 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion admin-dev/themes/default/template/controllers/groups/helpers/tree/tree_categories.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@
$("#{$id|escape:'html':'UTF-8'}").tree("collapseAll");

{if isset($selected_categories)}
{assign var=imploded_selected_categories value='","'|implode:$selected_categories}
Copy link
Contributor Author

@lmeyer1 lmeyer1 Jun 23, 2023 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code is not equivalent before and after. We must use implode('","', $selected_categories);
Nobody noticed it 😄

{assign var=imploded_selected_categories value=implode('","', $selected_categories)}
var selected_categories = new Array("{$imploded_selected_categories}");

$("#{$id|escape:'html':'UTF-8'}").find(":input").each(
Expand Down
2 changes: 1 addition & 1 deletion admin-dev/themes/default/template/helpers/tree/subtree_associated_categories.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@

<script type="text/javascript">
{if isset($selected_categories) && !empty($selected_categories)}
{assign var=imploded_selected_categories value='","'|implode:$selected_categories}
{assign var=imploded_selected_categories value=implode('","', $selected_categories)}
var selected_categories = new Array("{$imploded_selected_categories}");

$('#{$id_tree}').tree('collapseAll');
Expand Down
2 changes: 1 addition & 1 deletion admin-dev/themes/default/template/helpers/tree/tree_associated_categories.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@

{if isset($selected_categories)}
$('#no_default_category').hide();
{assign var=imploded_selected_categories value='","'|implode:$selected_categories}
{assign var=imploded_selected_categories value=implode('","', $selected_categories)}
var selected_categories = new Array("{$imploded_selected_categories}");

if (selected_categories.length > 1)
Expand Down
2 changes: 1 addition & 1 deletion admin-dev/themes/default/template/helpers/tree/tree_categories.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@
$("#{$id|escape:'html':'UTF-8'}").tree("collapseAll");

{if isset($selected_categories)}
{assign var=imploded_selected_categories value='","'|implode:$selected_categories}
{assign var=imploded_selected_categories value=implode('","', $selected_categories)}
var selected_categories = new Array("{$imploded_selected_categories}");

$("#{$id|escape:'html':'UTF-8'}").find(":input").each(
Expand Down
2 changes: 1 addition & 1 deletion admin-dev/themes/default/template/helpers/tree/tree_shops.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@
);

{if isset($selected_shops)}
{assign var=imploded_selected_shops value='","'|implode:$selected_shops}
{assign var=imploded_selected_shops value=implode('","', $selected_shops)}
var selected_shops = new Array("{$imploded_selected_shops}");

$("#{$id|escape:'html':'UTF-8'}").find(".tree-item :input").each(
Expand Down