Register commonly used deprecated modifiers to Smarty config

[kpodemski]

Questions	Answers
Branch?	8.1.x
Description?	I discovered that many Smarty modifiers were not available and threw deprecate warnings after the recent Smarty upgrade.
Type?	bug fix
Category?	CO
BC breaks?	no
Deprecations?	no
How to test?	Autotests and CI should be enough, to me, the best way to see before and after, was to see the modules translations page and theme translations page with debug mode enabled
Fixed ticket?	Fixes #32703
Related PRs	n/a
Sponsor company	Acme Company

[ga-devfront]

THANKS ! Not much to add the code speaks for itself.

[kpodemski]

cc @matks

[jolelievre]

Thanks @kpodemski

[Hlavtox]

Before, when visiting password reset page.

[19-Jul-2023 11:15:06 Europe/Prague] 
PHP Deprecated:  Using php-function "stripslashes" as a modifier is deprecated and will be removed in a future release. 
Use Smarty::registerPlugin to explicitly register a custom modifier. 
in C:\xampp\htdocs\81x\vendor\smarty\smarty\libs\sysplugins\smarty_internal_compile_private_modifier.php on line 114

After change, no errors. ✅

[SharakPL]

Looks like there are duplications in this file eg. floatval, intval, json_encode, mt_rand, trim...

PrestaShop/config/smarty.config.inc.php

Lines 105 to 115 in 23158f4

	smartyRegisterFunction($smarty, 'modifier', 'floatval', 'floatval');
	smartyRegisterFunction($smarty, 'modifier', 'htmlentities', 'htmlentities');
	smartyRegisterFunction($smarty, 'modifier', 'intval', 'intval');
	smartyRegisterFunction($smarty, 'modifier', 'json_decode', 'json_decode');
	smartyRegisterFunction($smarty, 'modifier', 'json_encode', 'json_encode');
	smartyRegisterFunction($smarty, 'modifier', 'mt_rand','mt_rand');
	smartyRegisterFunction($smarty, 'modifier', 'rand','rand');
	smartyRegisterFunction($smarty, 'modifier', 'strtolower','strtolower');
	smartyRegisterFunction($smarty, 'modifier', 'str_replace','str_replace');
	smartyRegisterFunction($smarty, 'modifier', 'strval','strval');
	smartyRegisterFunction($smarty, 'modifier', 'trim', 'trim');

PrestaShop/config/smarty.config.inc.php

Lines 128 to 136 in 23158f4

	smartyRegisterFunction($smarty, 'modifier', 'intval', 'intval');
	smartyRegisterFunction($smarty, 'modifier', 'date', 'date');
	smartyRegisterFunction($smarty, 'modifier', 'trim', 'trim');
	smartyRegisterFunction($smarty, 'modifier', 'json_encode', 'json_encode');
	smartyRegisterFunction($smarty, 'modifier', 'in_array', 'in_array');
	smartyRegisterFunction($smarty, 'modifier', 'stripslashes', 'stripslashes');
	smartyRegisterFunction($smarty, 'modifier', 'mt_rand', 'mt_rand');
	smartyRegisterFunction($smarty, 'modifier', 'md5', 'md5');
	smartyRegisterFunction($smarty, 'modifier', 'floatval', 'floatval');

Am I missing something or it does need a cleanup?

[neocol83]

// Native PHP Functions
smartyRegisterFunction($smarty, 'modifier', 'addcslashes', 'addcslashes');
smartyRegisterFunction($smarty, 'modifier', 'addslashes', 'addslashes');
smartyRegisterFunction($smarty, 'modifier', 'date','date');
smartyRegisterFunction($smarty, 'modifier', 'end', 'smarty_endWithoutReference');
smartyRegisterFunction($smarty, 'modifier', 'floatval', 'floatval');
smartyRegisterFunction($smarty, 'modifier', 'htmlentities', 'htmlentities');
smartyRegisterFunction($smarty, 'modifier', 'intval', 'intval');
smartyRegisterFunction($smarty, 'modifier', 'json_decode', 'json_decode');
smartyRegisterFunction($smarty, 'modifier', 'json_encode', 'json_encode');
smartyRegisterFunction($smarty, 'modifier', 'mt_rand','mt_rand');
smartyRegisterFunction($smarty, 'modifier', 'rand','rand');
smartyRegisterFunction($smarty, 'modifier', 'strtolower','strtolower');
smartyRegisterFunction($smarty, 'modifier', 'str_replace','str_replace');
smartyRegisterFunction($smarty, 'modifier', 'strval','strval');
smartyRegisterFunction($smarty, 'modifier', 'trim', 'trim');
smartyRegisterFunction($smarty, 'modifier', 'ucfirst', 'ucfirst');
smartyRegisterFunction($smarty, 'modifier', 'urlencode','urlencode');
smartyRegisterFunction($smarty, 'modifier', 'htmlspecialchars','htmlspecialchars');
smartyRegisterFunction($smarty, 'modifier', 'implode', 'implode');
smartyRegisterFunction($smarty, 'modifier', 'explode', 'explode');
smartyRegisterFunction($smarty, 'modifier', 'print_r', 'print_r');
smartyRegisterFunction($smarty, 'modifier', 'var_dump', 'var_dump');
smartyRegisterFunction($smarty, 'modifier', 'lcfirst', 'lcfirst');
smartyRegisterFunction($smarty, 'modifier', 'nl2br', 'nl2br');
smartyRegisterFunction($smarty, 'modifier', 'sizeof', 'sizeof');
smartyRegisterFunction($smarty, 'modifier', 'in_array', 'in_array');
smartyRegisterFunction($smarty, 'modifier', 'substr', 'substr');
smartyRegisterFunction($smarty, 'modifier', 'stripslashes', 'stripslashes');
smartyRegisterFunction($smarty, 'modifier', 'md5', 'md5');
smartyRegisterFunction($smarty, 'modifier', 'strtoupper', 'strtoupper');

I think maybe like that works

[ivordurham]

I encountered this problem today with array_merge in PrestaShop 8.1.3/PHP 8.1.25 when I first logged in to admin after a brand new install.

[SHOPPATH]/vendor/smarty/smarty/libs/sysplugins/smarty_internal_compile_private_modifier.php
[16384] Using php-function "array_merge" as a modifier is deprecated and will be removed in a future release. Use Smarty::registerPlugin to explicitly register a custom modifier.

[kpodemski]

It's true we don't have array_merge in https://github.com/PrestaShop/PrestaShop/blob/develop/config/smarty.config.inc.php