Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update autoload library to v1.0.1 #33148

Merged
merged 1 commit into from Jul 13, 2023
Merged

Update autoload library to v1.0.1 #33148

merged 1 commit into from Jul 13, 2023

Conversation

jolelievre
Copy link
Contributor

Questions Answers
Branch? 8.1.x
Description? Update autoload library
Type? bug fix
Category? CO
BC breaks? no
Deprecations? no
How to test? See PrestaShop/autoload#5 for description
Fixed ticket? ~
Related PRs ~
Sponsor company ~

@jolelievre jolelievre requested a review from a team as a code owner July 7, 2023 14:00
@prestonBot
Copy link
Collaborator

Hi, thanks for this contribution!

I found some issues with the Pull Request description:

  • Your pull request does not seem to fix any issue, consider creating one (see note below) and linking it by writing Fixes #1234.

Would you mind having a look at it? This will help us understand how interesting your contribution is, thank you very much!

About linked issues

Please consider opening an issue before submitting a Pull Request:

  • If it's a bug fix, it helps maintainers verify that the bug is effectively due to a defect in the code, and that it hasn't been fixed already.
  • It can help trigger a discussion about the best implementation path before a single line of code is written.
  • It may lead the Core Product team to mark that issue as a priority, further attracting the maintainers' attention.

(Note: this is an automated message, but answering it will reach a real human)

@prestonBot prestonBot added 8.1.x Branch Bug fix Type: Bug fix labels Jul 7, 2023
@jolelievre jolelievre changed the title Update autoload library Update autoload library to v1.0.1 Jul 7, 2023
@ps-jarvis ps-jarvis added the Waiting for QA Status: action required, waiting for test feedback label Jul 7, 2023
@djoelleuch
Copy link

Hello @jolelievre , Some checks were not successful could you pease check it !
Thank you

@djoelleuch djoelleuch added Waiting for author Status: action required, waiting for author feedback and removed Waiting for QA Status: action required, waiting for test feedback labels Jul 7, 2023
@kpodemski
Copy link
Contributor

kpodemski commented Jul 7, 2023 •
edited

It's related to my PR. Why didn't PHPStan block it inside my PR? 🤯

Edit: and now tests are all green, not sure what happened :)

@kpodemski kpodemski added Waiting for QA Status: action required, waiting for test feedback Waiting for dev Status: action required, waiting for tech feedback and removed Waiting for author Status: action required, waiting for author feedback labels Jul 10, 2023
@kpodemski kpodemski added this to the 8.1.1 milestone Jul 10, 2023
@kpodemski
Copy link
Contributor

@PrestaShop/qa-functional I'm marking this to be validated by a dev as it's a technical issue

@jolelievre
Copy link
Contributor Author

I already performed a QA by dev on the lib change PR here PrestaShop/autoload#5
I'm not sure it's worth doing it again 🤔

@jolelievre
Copy link
Contributor Author

Running campaign of UI tests https://github.com/jolelievre/ga.tests.ui.pr/actions/runs/5512478109

@jolelievre jolelievre added QA ✔️ Status: check done, code approved and removed Waiting for QA Status: action required, waiting for test feedback Waiting for dev Status: action required, waiting for tech feedback labels Jul 13, 2023
@jolelievre jolelievre merged commit 3ee88f2 into PrestaShop:8.1.x Jul 13, 2023
55 of 58 checks passed
@jolelievre jolelievre deleted the autoload-update branch July 13, 2023 08:40
@jolelievre
Copy link
Contributor Author

The initial PR was already tested so it's ok to merge this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FabienPapet FabienPapet FabienPapet approved these changes

@matks matks matks approved these changes

@lartist lartist lartist approved these changes

@boherm boherm boherm approved these changes

Assignees
No one assigned
Labels
8.1.x Branch Bug fix Type: Bug fix QA ✔️ Status: check done, code approved
Projects
PR Dashboard
Archived in project
Milestone
8.1.1
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@jolelievre @prestonBot @djoelleuch @kpodemski @FabienPapet @matks @lartist @boherm @ps-jarvis