New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove usage of multiaddress delivery #33264
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prestonBot
added
develop
Branch
Refactoring
Type: Refactoring
BC break
Type: Introduces a backwards-incompatible break
labels
Jul 15, 2023
Hlavtox
force-pushed
the
remove-multiaddress
branch
2 times, most recently
from
July 15, 2023 10:20
fe14b7c
to
7d6bff5
Compare
Hlavtox
added
the
Needs documentation
Needs an update of the developer documentation
label
Jul 15, 2023
Hlavtox
force-pushed
the
remove-multiaddress
branch
3 times, most recently
from
August 2, 2023 15:38
e5d7815
to
1187e89
Compare
Hlavtox
force-pushed
the
remove-multiaddress
branch
from
August 3, 2023 10:53
1187e89
to
89ad83c
Compare
Hlavtox
force-pushed
the
remove-multiaddress
branch
from
August 3, 2023 11:38
0ada5b7
to
3e5f376
Compare
Closed
matthieu-rolland
approved these changes
Aug 9, 2023
M0rgan01
approved these changes
Sep 7, 2023
ps-jarvis
added
the
Waiting for QA
Status: action required, waiting for test feedback
label
Sep 7, 2023
boherm
approved these changes
Sep 8, 2023
MhiriFaten
approved these changes
Sep 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @Hlavtox ,
I have checked your PR ad LGTM,
Automated tests are OK.
https://github.com/MhiriFaten/testing_pr/actions/runs/6119472501
It is QA approved ✔️
MhiriFaten
removed
the
Waiting for QA
Status: action required, waiting for test feedback
label
Sep 8, 2023
QA approved, well done! Message to the maintainers: do not forget to milestone it before the merge. |
Thanks @Hlavtox! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
BC break
Type: Introduces a backwards-incompatible break
develop
Branch
Needs documentation
Needs an update of the developer documentation
QA ✔️
Status: check done, code approved
Refactoring
Type: Refactoring
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
cart
everywhere and the values incart_product
andcustomization
are ignored.Removed methods
Deprecated methods
Removed configuration options