Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove usage of multiaddress delivery #33264

Merged
merged 4 commits into from Sep 8, 2023

Conversation

Hlavtox
Copy link
Contributor

@Hlavtox Hlavtox commented Jul 15, 2023

Questions Answers
Branch? develop
Description? See below
Type? refacto
Category? CO
BC breaks? yes - but I doubt that anybode will be affected since this feature is dead for whole lifetime of 1.7. No method signatures have been changed, all methods still return the same data. I didn't touch the structure of delivery methods etc. - they are still structured with that one single delivery address ID.
Deprecations? yes
How to test?
Fixed ticket?
Related PRs
Sponsor company

Description

  • Removes code related to a dead feature of multi-address shipping. (Order still can be split and have multiple packages - do not confuse it.)
  • Delivery address is now taken from the cart everywhere and the values in cart_product and customization are ignored.
  • They are initially filled with values for one more major, but deprecated.
  • All the data structures have been kept the same. Customized datas are returned the same, package lists are returned the same.

Removed methods

  • Cart::containsProduct
  • Cart::getDeliveryAddressesWithoutCarriers

Deprecated methods

  • Cart::isMultiAddressDelivery - returns false
  • Cart::getAddressCollection - returns cart's delivery address or empty array
  • Cart::setProductAddressDelivery - doesn't do anything, return true
  • Cart::duplicateProduct - doesn't do anything, returns false, you cannot duplicate product in a cart
  • Cart::setNoMultishipping - doesn't do anything
  • Cart::autosetProductAddress - doesn't do anything

Removed configuration options

  • PS_ALLOW_MULTISHIPPING

@prestonBot prestonBot added develop Branch Refactoring Type: Refactoring BC break Type: Introduces a backwards-incompatible break labels Jul 15, 2023
@Hlavtox Hlavtox force-pushed the remove-multiaddress branch 2 times, most recently from fe14b7c to 7d6bff5 Compare July 15, 2023 10:20
@Hlavtox Hlavtox added the Needs documentation Needs an update of the developer documentation label Jul 15, 2023
@Hlavtox Hlavtox force-pushed the remove-multiaddress branch 3 times, most recently from e5d7815 to 1187e89 Compare August 2, 2023 15:38
@Hlavtox Hlavtox marked this pull request as ready for review August 2, 2023 15:40
@Hlavtox Hlavtox requested a review from a team as a code owner August 2, 2023 15:40
@ps-jarvis ps-jarvis added the Waiting for QA Status: action required, waiting for test feedback label Sep 7, 2023
@MhiriFaten MhiriFaten self-assigned this Sep 8, 2023
Copy link

@MhiriFaten MhiriFaten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @Hlavtox ,

I have checked your PR ad LGTM,
Automated tests are OK.
https://github.com/MhiriFaten/testing_pr/actions/runs/6119472501

It is QA approved ✔️

@MhiriFaten MhiriFaten removed the Waiting for QA Status: action required, waiting for test feedback label Sep 8, 2023
@MhiriFaten MhiriFaten added the QA ✔️ Status: check done, code approved label Sep 8, 2023
@prestonBot
Copy link
Collaborator

QA approved, well done! Message to the maintainers: do not forget to milestone it before the merge.

@boherm boherm added this to the 9.0.0 milestone Sep 8, 2023
@boherm boherm merged commit 8084980 into PrestaShop:develop Sep 8, 2023
18 checks passed
@boherm
Copy link
Member

boherm commented Sep 8, 2023

Thanks @Hlavtox!

@Hlavtox Hlavtox deleted the remove-multiaddress branch September 8, 2023 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BC break Type: Introduces a backwards-incompatible break develop Branch Needs documentation Needs an update of the developer documentation QA ✔️ Status: check done, code approved Refactoring Type: Refactoring
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

7 participants