Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change translation key when enable/disable/delete product #33296

Merged
merged 1 commit into from Jul 27, 2023
Merged

Change translation key when enable/disable/delete product #33296

merged 1 commit into from Jul 27, 2023

Conversation

mflasquin
Copy link
Contributor

@mflasquin mflasquin commented Jul 18, 2023 •
edited by Hlavtox

Questions Answers
Branch? 8.1.x
Description? Change translation key when enable/disable/delete product. Additional translation to finish to fix the issue #31778 after the PR #32993. Ping @MatShir
Type? improvement
Category? BO
BC breaks? no
Deprecations? no
How to test? See #31778
Fixed ticket? Fixes #31778
Related PRs #32993
Sponsor company Prestasop SA

@mflasquin mflasquin requested a review from a team as a code owner July 18, 2023 14:49
@prestonBot prestonBot added develop Branch Improvement Type: Improvement labels Jul 18, 2023
MatShir
MatShir previously requested changes Jul 18, 2023
View reviewed changes
Copy link
Contributor

@MatShir MatShir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you target 8.1.x ? 🙏

@ps-jarvis ps-jarvis added the Waiting for author Status: action required, waiting for author feedback label Jul 18, 2023
@mflasquin mflasquin changed the base branch from develop to 8.1.x July 18, 2023 15:07
@mflasquin mflasquin requested a review from a team as a code owner July 18, 2023 15:07
@mflasquin mflasquin changed the base branch from 8.1.x to develop July 18, 2023 15:07
@mflasquin
Copy link
Contributor Author

Could you target 8.1.x ? pray

The last PR was targetting develop : #32993

@prestashop-issue-bot prestashop-issue-bot bot removed the Waiting for author Status: action required, waiting for author feedback label Jul 18, 2023
nicosomb
nicosomb previously approved these changes Jul 18, 2023
View reviewed changes
@MatShir
Copy link
Contributor

MatShir commented Jul 18, 2023 •
edited

The issue was milestone for the 8.1.x, for a wording it's sad to wait for the v9

@mflasquin mflasquin changed the base branch from develop to 8.1.x July 18, 2023 15:16
@mflasquin
Copy link
Contributor Author

The issue was milestone for the 8.1.x, for a wording it's sad to wait for the v9

Changed. The update alreay present on develop as been added on 8.1.x

@mflasquin mflasquin modified the milestone: 8.1.1 Jul 18, 2023
@MatShir MatShir added this to the 8.1.2 milestone Jul 19, 2023
@matthieu-rolland matthieu-rolland dismissed MatShir’s stale review July 19, 2023 14:57

change has been applied

@ps-jarvis ps-jarvis added the Waiting for QA Status: action required, waiting for test feedback label Jul 19, 2023
@mflasquin mflasquin closed this Jul 20, 2023
@mflasquin mflasquin reopened this Jul 20, 2023
@MhiriFaten MhiriFaten self-assigned this Jul 21, 2023
MhiriFaten
MhiriFaten reviewed Jul 21, 2023
View reviewed changes
Copy link

@MhiriFaten MhiriFaten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @mflasquin ,

I have checked your PR and I noticed the issue still exist :

Untitled_.Jul.21.2023.3_50.PM.webm

And on the image of the copied product is not well displayed

Untitled_.Jul.21.2023.3_51.PM.webm

Could you check it please ?

@MhiriFaten MhiriFaten added Waiting for author Status: action required, waiting for author feedback and removed Waiting for QA Status: action required, waiting for test feedback labels Jul 21, 2023
@MhiriFaten MhiriFaten removed their assignment Jul 21, 2023
@mflasquin
Copy link
Contributor Author

Hi @MhiriFaten can you check on develop, I think It's not linked to my PR (I just change 4 translations..)

@mflasquin mflasquin added Waiting for QA Status: action required, waiting for test feedback and removed Waiting for author Status: action required, waiting for author feedback labels Jul 25, 2023
@nesrineabdmouleh
Copy link
Contributor

UI tests => https://github.com/nesrineabdmouleh/testing_pr/actions/runs/5654729478

@prestonBot prestonBot added the 8.1.x Branch label Jul 26, 2023
@Hlavtox Hlavtox removed the develop Branch label Jul 26, 2023
@djoelleuch djoelleuch self-assigned this Jul 27, 2023
djoelleuch
djoelleuch approved these changes Jul 27, 2023
View reviewed changes
Copy link

@djoelleuch djoelleuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @mflasquin ,
the wording is OK ✔️

Untitled_.Jul.27.2023.11_34.AM.webm

Automated tests are OK .
but the real issue is not fixing !

thank you for your PR .

@djoelleuch djoelleuch added QA ✔️ Status: check done, code approved and removed Waiting for QA Status: action required, waiting for test feedback labels Jul 27, 2023
@kpodemski kpodemski merged commit c5d6eaf into PrestaShop:8.1.x Jul 27, 2023
38 checks passed
@kpodemski
Copy link
Contributor

thanks @mflasquin

@MatShir
Copy link
Contributor

MatShir commented Jul 27, 2023

Hi @djoelleuch,
What is left to do to fix the issue? So I can update it accordingly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MhiriFaten MhiriFaten MhiriFaten left review comments

@matthieu-rolland matthieu-rolland matthieu-rolland approved these changes

@boherm boherm boherm approved these changes

@nesrineabdmouleh nesrineabdmouleh nesrineabdmouleh approved these changes

@djoelleuch djoelleuch djoelleuch approved these changes

@nicosomb nicosomb nicosomb left review comments

@MatShir MatShir MatShir left review comments

Assignees

@djoelleuch djoelleuch

Labels
8.1.x Branch Improvement Type: Improvement QA ✔️ Status: check done, code approved
Projects
PR Dashboard
Archived in project
Milestone
8.1.2
Development

Successfully merging this pull request may close these issues.

BO - Multistore - PPV2 - Some issues when duplicating a product for all stores by Build actions