Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check if external carrier module exists #33495

Merged
merged 1 commit into from Jul 31, 2023
Merged

Check if external carrier module exists #33495

merged 1 commit into from Jul 31, 2023

Conversation

Hlavtox
Copy link
Contributor

@Hlavtox Hlavtox commented Jul 30, 2023 •
edited

Questions Answers
Branch? 8.1.x
Description? Check if external carrier module exists to prevent a crash in order view. Simmilar check like here:

PrestaShop/classes/Cart.php

Line 3751 in 6f5126c

if (!Validate::isLoadedObject($module)) {
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
How to test? You can try to simulate the issue (steps in the issue), or just look at the code and trust me. :-)
Fixed ticket? Fixes #33494
Related PRs
Sponsor company

@Hlavtox Hlavtox requested a review from a team as a code owner July 30, 2023 19:10
@prestonBot prestonBot added 8.1.x Branch Bug fix Type: Bug fix labels Jul 30, 2023
@Hlavtox Hlavtox added this to the 8.1.2 milestone Jul 30, 2023
@ps-jarvis ps-jarvis added the Waiting for QA Status: action required, waiting for test feedback label Jul 31, 2023
@Hlavtox
Copy link
Contributor Author

Hlavtox commented Jul 31, 2023

@PrestaShop/qa-functional Hi guys, can we merge this without QA? The issue would be hard to reproduce anyway and the change is trivial. 👍

@hibatallahAouadni hibatallahAouadni self-assigned this Jul 31, 2023
hibatallahAouadni
hibatallahAouadni approved these changes Jul 31, 2023
View reviewed changes
Copy link
Contributor

@hibatallahAouadni hibatallahAouadni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @Hlavtox

Thanks for your PR 🚀
LGTM, QA ✅
The auto tests are green 🟢 except the FacetedSearch which is not related to your PR (cause it's down even without your PR). https://github.com/hibatallahAouadni/testing_pr/actions/runs/5715389170

Thanks!

@hibatallahAouadni hibatallahAouadni added QA ✔️ Status: check done, code approved and removed Waiting for QA Status: action required, waiting for test feedback labels Jul 31, 2023
@Hlavtox Hlavtox merged commit 277cddd into PrestaShop:8.1.x Jul 31, 2023
38 checks passed
@Hlavtox Hlavtox deleted the check-external-module-name branch July 31, 2023 15:35
@Hlavtox
Copy link
Contributor Author

Hlavtox commented Jul 31, 2023

Thanks to the best tester in the world @hibatallahAouadni

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FabienPapet FabienPapet FabienPapet approved these changes

@kpodemski kpodemski kpodemski approved these changes

@boherm boherm boherm approved these changes

@hibatallahAouadni hibatallahAouadni hibatallahAouadni approved these changes

Assignees

@hibatallahAouadni hibatallahAouadni

Labels
8.1.x Branch Bug fix Type: Bug fix QA ✔️ Status: check done, code approved
Projects
PR Dashboard
Archived in project
Milestone
8.1.2
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@Hlavtox @FabienPapet @kpodemski @boherm @hibatallahAouadni @ps-jarvis @prestonBot