Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry downloading language packs #33515

Merged
merged 2 commits into from Aug 3, 2023
Merged

Conversation

Hlavtox
Copy link
Contributor

@Hlavtox Hlavtox commented Aug 1, 2023

Questions Answers
Branch? 8.1.x
Description? Tries to avoid temporary failures by attempting to download a language pack several times.
Type? improvement
Category? CO
BC breaks? no
Deprecations? no
How to test? Check that you can update language pack correctly from back office
Fixed ticket? Fixes #33514
Related PRs
Sponsor company

@Hlavtox Hlavtox requested a review from a team as a code owner August 1, 2023 07:00
@prestonBot prestonBot added 8.1.x Branch Improvement Type: Improvement labels Aug 1, 2023
@Hlavtox Hlavtox added this to the 8.1.2 milestone Aug 1, 2023
kpodemski
kpodemski previously approved these changes Aug 1, 2023
Copy link
Contributor

@matthieu-rolland matthieu-rolland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a nice quality of live improvement 👍

Copy link
Member

@boherm boherm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement! Thanks @Hlavtox 🙂

@ps-jarvis ps-jarvis added the Waiting for QA Status: action required, waiting for test feedback label Aug 1, 2023
@sallemiines sallemiines self-assigned this Aug 2, 2023
Copy link
Contributor

@sallemiines sallemiines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @Hlavtox

Thnx for the PR LGTM QA ✔️

Thank you

Copy link
Contributor

@sallemiines sallemiines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @Hlavtox

Thnx for the PR LGTM QA ✔️

Thank you

@sallemiines sallemiines added QA ✔️ Status: check done, code approved and removed Waiting for QA Status: action required, waiting for test feedback labels Aug 3, 2023
@Hlavtox Hlavtox merged commit 6611bf8 into PrestaShop:8.1.x Aug 3, 2023
38 checks passed
@Hlavtox Hlavtox deleted the retry-langs branch August 3, 2023 10:34
@Hlavtox
Copy link
Contributor Author

Hlavtox commented Aug 3, 2023

Thank youuuuu @sallemiines!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.1.x Branch Improvement Type: Improvement QA ✔️ Status: check done, code approved
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

7 participants