Fix visual issues new product page

[boherm]

Questions	Answers
Branch?	8.1.x
Description?	Fix some issues in new product page.
Type?	bug fix
Category?	BO
BC breaks?	no
Deprecations?	no
How to test?	See #32214
Fixed ticket?	Fixes #32214
Related PRs
Sponsor company	PrestaShop SA

[Hlavtox]

Quick check/test

1 - If you have a multi-lang site, language iso-codes should be uppercase (this is a feature request ;-)) FIXED
2 - Element below indicates whether the field is required or not, but there's no label explaining that. FIXED, but I would switch the required and delete button, delete should be at the end.
3 - What do you want me to type there? Missing placeholder. - FIXED
4 - Link below is misaligned. It is not in the center, it is not to the left, etc. FIXED
5 - There are a few issues there. The help text doesn't look like a help text, warning/info text doesn't look like one. IMPROVED
6 - Worth considering making it more readable. (feature request) - FIXED, collapse added
7 - When you click this button, it gets a weird border covering part of the text. 🔴 PARTIALLY FIXED - @boherm add some margin under the helptext or something, or margin top on the button?
8 - I don't understand this part. What is this currency for? I have PLN but still the EUR symbol on the left. (edit, ok, it doesn't change dynamically). 🔴 NOT FIXED?

[boherm]

Hi @Hlavtox, thanks for your review ;)

7 - When you click this button, it gets a weird border covering part of the text. 🔴 PARTIALLY FIXED - @boherm add some margin under the helptext or something, or margin top on the button?

Yeah, why not to add a margin.
I just add the "disable" button behavior thing when we don't have a change on the friendly url.

8 - I don't understand this part. What is this currency for? I have PLN but still the EUR symbol on the left. (edit, ok, it doesn't change dynamically). 🔴 NOT FIXED?

Weird 🤔 Have you correctly rebuild the new theme?

[Hlavtox]

@MatShir @TristanLDD Guys one more improvement regarding the specific prices.

• Disable one checkbox, if you enable the other one?
• What about adding A) and B) or something before the two discount options?

(automatic translation in chrome)

[MatShir]

If I remember well both can be applied so, that's why it is not like a switch behavior.

[boherm]

Yo @Hlavtox, I've fix the 7th and 8th items.
For the 8th, I don't reproduce on my side but maybe it's a browser compatibility issue.
Anyway, with the fix I've done, this could be working on your side now.

If you have some time, can you recheck that? 🙏

[Hlavtox]

@boherm I will test it during the weekend 👍

[aniszr]

Hello @boherm

I tested your PR, almost all of your improvements are well displayed.

See attached screenrecord:

Products.Prestashop81x.mp4

The only failed improvement is :

• Mobile -> Tab Stock -> Fix display for Add or subtract item input ❌
  See attached screenshot:
  

Could you please check and feedback!

Thanks!

[Hlavtox]

@aniszr Anis, does this work? You must show it. :)

[aniszr]

Hello @Hlavtox

Thanks for your feedback.

I retested the currancy changing behavior and found that Cost price (tax excl.) don't change automatically the currency symbol when we assign a new Currency! Unless we click save and publish!!

See attached screenrecord:

Localization.Prestashop81x.mp4

Thanks!

[boherm]

Hello @aniszr,
Have you really rebuild assets (and precisely admin-new-theme) before testing? 🤔
It's reaaaaaally weird...

[aniszr]

Hello @boherm

I retested your PR and make sure that cache is cleared and admin-new-theme is well generated ✔️

The previousely mentioned problems are solved :

• Mobile -> Tab Stock -> Fix display for Add or subtract item input ✔️
• The Cost price(tax excl.) currency symbol is responsively changed when changing Currency field ✔️

See attached screenrecord:

Inbox.90.-.anis-zouari.ext@prestashop.com.-.Prestashop.SA.Mail.mp4

Auto Test : https://github.com/aniszr/ga.tests.ui.pr/actions/runs/5832815208 ✔️

QA ✔️

Thank you!

[prestonBot]

QA approved, well done! Message to the maintainers: do not forget to milestone it before the merge.

[MatShir]

🎉 thanks everyone