New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: issue when clearing cache with opcache with enable_file_override #33658
Conversation
Hi, thanks for this contribution! I found some issues with the Pull Request description:
Would you mind having a look at it? This will help us understand how interesting your contribution is, thank you very much! About linked issuesPlease consider opening an issue before submitting a Pull Request:
(Note: this is an automated message, but answering it will reach a real human) |
hey @Tofandel there are some problems with your PR:
You can also propose this change against the 8.1.x branch because it's a valid improvement 👍🏻 |
f93063a
to
aad7c19
Compare
I rebased on 8.1.x and fixed the style issue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @Tofandel
LGTM, QA ✅ and auto tests are 🟢 except the Product V2 and it's not related to your PR.
https://github.com/hibatallahAouadni/testing_pr/actions/runs/5975852106
Thanks!
QA approved, well done! Message to the maintainers: do not forget to milestone it before the merge. |
enable_file_override=1
andvalidate_timestamps=0
when clearing the cache from the admin thevar/cache/prop/appParameters.php
file is created with permissions000
and is then unreadable and needs to be removed manually, this is becausefile_exists
will return true, butfileperms
will return 0 because the file doesn't actually exist500
it's working correctlyIn any case it's a good idea to also reset opcache when the user clears the cache manually