Fix PDO prepare for CVE-2023-39524 #33758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
clotairer
commented
Aug 29, 2023
•
clotairer
commented
| Questions | Answers |
|---|---|
| Branch? | develop |
| Description? | Instead of using the legacy method pSQL() use a proper "prepare" via PDO. |
| Type? | refacto |
| Category? | BO |
| BC breaks? | no |
| Deprecations? | no |
| How to test? | As a backoffice user, go to "edit a product" V2 page, verify the search field for "associated product" works correctly |
| Fixed issue or discussion? | Fixes #33759 |
| Related PRs | NC |
| Sponsor company | @202-ecommerce |
matthieu-rolland
approved these changes
Aug 29, 2023
2 tasks
matks
reviewed
Aug 29, 2023
There was a problem hiding this comment.
Hello @clotairer and @matthieu-rolland what is the branch choice for this PR? Currently it targets develop but PR table says develop / 8.1.x
For me, it's just a refactoring. No emergency. |
matks
approved these changes
Aug 29, 2023
ps-jarvis
added
the
Waiting for QA
kpodemski
previously requested changes
Aug 29, 2023
There was a problem hiding this comment.
I believe this should go inside the 8.1.x branch.
Edit: I see comment above now, nothing to change. Thanks @clotairer
ps-jarvis
added
the
Waiting for author
kpodemski
added
Waiting for dev
PululuK
approved these changes
Aug 29, 2023
|
UI tests https://github.com/nicosomb/ga.tests.ui.pr/actions/runs/6108071781 if all is ✅ , we can merge. |
|
thank you @clotairer ! |
matthieu-rolland
removed
Waiting for QA
jolelievre
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.