Update classname regex to allow FQDN

[gross-nvs]

Questions	Answers
Branch?	8.1.x
Description?	Fix classname validation in Validate not allowing FQDN classnames
Type?	bug fix
Category?	BO
BC breaks?	no
Deprecations?	no
How to test?	Install the following test module, then click on 'Configure' to trigger the test case. If no error message is displayed and a log line is properly added to the log list (Advances parameters > Logs) then the fix works. test_33590.zip
Fixed issue or discussion?	Fixes #33590
Related PRs
Sponsor company	Novius

[prestonBot]

Hello @gross-nvs!

This is your first pull request on the PrestaShop project. Thank you, and welcome to this Open Source community!

[prestonBot]

Hi, thanks for this contribution!

I found some issues with the Pull Request description:

• Your pull request does not seem to fix any issue, consider creating one (see note below) and linking it by writing Fixes #1234.

Would you mind having a look at it? This will help us understand how interesting your contribution is, thank you very much!

About linked issues

Please consider opening an issue before submitting a Pull Request:

• If it's a bug fix, it helps maintainers verify that the bug is effectively due to a defect in the code, and that it hasn't been fixed already.
• It can help trigger a discussion about the best implementation path before a single line of code is written.
• It may lead the Core Product team to mark that issue as a priority, further attracting the maintainers' attention.

(Note: this is an automated message, but answering it will reach a real human)

[matthieu-rolland]

👍

[kpodemski]

Could you target 8.1.x branch?

[kpodemski]

@PrestaShop/qa-functional I restarted the tests but feel free to test the PR anyway, I'm positive they'll be green ;-)

[paulnoelcholot]

@kpodemski They are not green ^^ Someone, but not all ;p

[paulnoelcholot]

Hello @gross-nvs,

Some checks were not successful, can you look into that? :)

Thanks!

[gross-nvs]

Hi @paulnoelcholot

By looking the details, I'm afraid I'm not qualified to fix those problems, nor are they related to the code change.

[kpodemski]

@gross-nvs no worries, it's the issue on our side - or rather a GH side :D

[MhiriFaten]

Hello @gross-nvs ,

I have checked the PR, no error message is displayed and a log line is properly added to the log list.
But I noticed that the autolated tests failed in test (functional:productV2, 8.1.x)

@PrestaShop/qa-automation is this failure related to the PR ?

[nicosomb]

Thank you @gross-nvs !