Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Functional Tests : BO - Stocks - Movements - Filter by category, movement type, employee and period #33787

Merged
merged 1 commit into from Oct 20, 2023
Merged

Functional Tests : BO - Stocks - Movements - Filter by category, movement type, employee and period #33787

merged 1 commit into from Oct 20, 2023

Conversation

Progi1984
Copy link
Contributor

@Progi1984 Progi1984 commented Sep 1, 2023 •
edited

Questions Answers
Branch? develop
Description? Functional Tests : BO - Stocks - Movements - Filter by category, movement type, employee and period
Type? improvement
Category? TE
BC breaks? no
Deprecations? no
How to test? CI is 🟢 & Nightly is 🟢 : https://github.com/Progi1984/ga.tests.ui.pr/actions/runs/6262725385
Fixed issue or discussion? N/A
Related PRs N/A
Sponsor company @PrestaShopCorp

Detected issues :

@Progi1984 Progi1984 added TE Category: Tests E2E Tests labels Sep 1, 2023
@Progi1984 Progi1984 added this to the 9.0.0 milestone Sep 1, 2023
@prestonBot prestonBot added develop Branch Improvement Type: Improvement labels Sep 1, 2023
@Progi1984 Progi1984 force-pushed the test846 branch 25 times, most recently from cded55f to 507a847 Compare September 6, 2023 11:42
@Progi1984 Progi1984 force-pushed the test846 branch 13 times, most recently from 291610b to 4d363c0 Compare October 20, 2023 11:40
@Progi1984 Progi1984 marked this pull request as ready for review October 20, 2023 12:59
@Progi1984 Progi1984 requested review from a team as code owners October 20, 2023 12:59
boherm
boherm approved these changes Oct 20, 2023
View reviewed changes
Copy link
Member

@boherm boherm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@boubkerbribri boubkerbribri merged commit 48daa68 into PrestaShop:develop Oct 20, 2023
21 checks passed
@boubkerbribri boubkerbribri added the QA ✔️ Status: check done, code approved label Oct 20, 2023
@boubkerbribri
Copy link
Contributor

Thanks @Progi1984

@Progi1984 Progi1984 deleted the test846 branch October 20, 2023 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boherm boherm boherm approved these changes

@nesrineabdmouleh nesrineabdmouleh nesrineabdmouleh approved these changes

@boubkerbribri boubkerbribri boubkerbribri approved these changes

Assignees
No one assigned
Labels
develop Branch E2E Tests Improvement Type: Improvement QA ✔️ Status: check done, code approved TE Category: Tests
Projects
None yet
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Progi1984 @boubkerbribri @boherm @nesrineabdmouleh @prestonBot