Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add htaccess to protect templates dir #33788

Merged
merged 1 commit into from Sep 1, 2023
Merged

Add htaccess to protect templates dir #33788

merged 1 commit into from Sep 1, 2023

Conversation

nicosomb
Copy link
Contributor

@nicosomb nicosomb commented Sep 1, 2023

Questions Answers
Branch? 8.1.x
Description? Fixes #33722 by adding an htaccess to protect the templates directory, backport of #33723. Thank you @maxime-profileo ❤️
Type? bug fix
Category? FO
BC breaks? no
Deprecations? no
How to test? See #33722
Fixed issue or discussion? Fixes #33722
Related PRs
Sponsor company PrestaShop SA

@nicosomb nicosomb added this to the 8.1.2 milestone Sep 1, 2023
@nicosomb nicosomb requested a review from a team as a code owner September 1, 2023 08:50
@prestonBot
Copy link
Collaborator

Hi, thanks for this contribution!

I found some issues with the Pull Request description:

  • Your pull request does not seem to fix any issue, consider creating one (see note below) and linking it by writing Fixes #1234.

Would you mind having a look at it? This will help us understand how interesting your contribution is, thank you very much!

About linked issues

Please consider opening an issue before submitting a Pull Request:

  • If it's a bug fix, it helps maintainers verify that the bug is effectively due to a defect in the code, and that it hasn't been fixed already.
  • It can help trigger a discussion about the best implementation path before a single line of code is written.
  • It may lead the Core Product team to mark that issue as a priority, further attracting the maintainers' attention.

(Note: this is an automated message, but answering it will reach a real human)

@prestonBot prestonBot added 8.1.x Branch Bug fix Type: Bug fix labels Sep 1, 2023
@nicosomb nicosomb mentioned this pull request Sep 1, 2023
Merged
@ps-jarvis ps-jarvis added the Waiting for QA Status: action required, waiting for test feedback label Sep 1, 2023
matks
matks approved these changes Sep 1, 2023
View reviewed changes
Copy link
Contributor

@matks matks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for me 👍

@matks matks added Waiting for dev Status: action required, waiting for tech feedback QA ✔️ Status: check done, code approved and removed Waiting for QA Status: action required, waiting for test feedback Waiting for dev Status: action required, waiting for tech feedback labels Sep 1, 2023
@matks
Copy link
Contributor

matks commented Sep 1, 2023

Thank you @nicosomb and @maxime-profileo

@matks matks merged commit f8c0e33 into PrestaShop:8.1.x Sep 1, 2023
38 checks passed
@matks matks changed the title Add htaccess to fix 33722 Add htaccess to protect templates dir Sep 1, 2023
@nicosomb nicosomb deleted the backport-33723 branch September 4, 2023 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matks matks matks approved these changes

@PululuK PululuK PululuK approved these changes

Assignees
No one assigned
Labels
8.1.x Branch Bug fix Type: Bug fix QA ✔️ Status: check done, code approved
Projects
PR Dashboard
Archived in project
Milestone
8.1.2
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@nicosomb @prestonBot @matks @PululuK @ps-jarvis @maxime-morel