New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix uninstalling modules with deleted hooks. #33802
Conversation
Hi, thanks for this contribution! I found some issues with the Pull Request description:
Would you mind having a look at it? This will help us understand how interesting your contribution is, thank you very much! About linked issuesPlease consider opening an issue before submitting a Pull Request:
(Note: this is an automated message, but answering it will reach a real human) |
779fb34
to
5585230
Compare
5585230
to
9ac6e18
Compare
Co-authored-by: PululuK <pululuandre@hotmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @Hlavtox!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Hlavtox
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @Hlavtox ,
I have checked your PR and the uninstalling modules with deleted hooks problem is fixed.
Automated tests are OK.
QA approved, well done! Message to the maintainers: do not forget to milestone it before the merge. |
Thank you @Hlavtox |
How to reproduce
gSitemapAppendUrls
.gSitemapAppendUrls
.gSitemapAppendUrls
.Cannot Uninstall module tox_hooktest. The hook id #405 does not exist in database.