Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make MobileQuickAccess twig component independent #33832

Merged
merged 1 commit into from Sep 5, 2023
Merged

Make MobileQuickAccess twig component independent #33832

merged 1 commit into from Sep 5, 2023

Conversation

boherm
Copy link
Member

@boherm boherm commented Sep 4, 2023 •
edited

Questions Answers
Branch? develop
Description? Make MobileQuickAccess twig component independent.
Type? improvement
Category? BO
BC breaks? no
Deprecations? no
How to test? CI 🟢 & UI tests 🟢
UI Tests - Legacy: https://github.com/boherm/ga.tests.ui.pr/actions/runs/6082756791
- Symfony: https://github.com/boherm/ga.tests.ui.pr/actions/runs/6082757825
Fixed issue or discussion? Fixes #33803
Related PRs
Sponsor company PrestaShop SA

@boherm boherm requested a review from a team as a code owner September 4, 2023 13:49
@prestonBot prestonBot added develop Branch Improvement Type: Improvement labels Sep 4, 2023
@boherm boherm added this to the 9.0.0 milestone Sep 4, 2023
@boherm
Copy link
Member Author

boherm commented Sep 5, 2023

All tests UI are ✅ :)

@M0rgan01 M0rgan01 assigned M0rgan01 and unassigned M0rgan01 Sep 5, 2023
@M0rgan01 M0rgan01 added the Waiting for QA Status: action required, waiting for test feedback label Sep 5, 2023
@MhiriFaten MhiriFaten self-assigned this Sep 5, 2023
@MhiriFaten MhiriFaten added QA ✔️ Status: check done, code approved and removed Waiting for QA Status: action required, waiting for test feedback labels Sep 5, 2023
@M0rgan01 M0rgan01 merged commit 445e09c into PrestaShop:develop Sep 5, 2023
18 checks passed
@M0rgan01
Copy link
Contributor

M0rgan01 commented Sep 5, 2023

Thanks @boherm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicosomb nicosomb nicosomb approved these changes

@M0rgan01 M0rgan01 M0rgan01 approved these changes

Assignees

@MhiriFaten MhiriFaten

Labels
develop Branch Improvement Type: Improvement QA ✔️ Status: check done, code approved
Projects
PR Dashboard
Archived in project
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.

Make MobileAccess Twig component independent
5 participants
@boherm @M0rgan01 @nicosomb @prestonBot @MhiriFaten