Fix adding and deleting language entries from tables

[Hlavtox]

Questions	Answers
Branch?	8.1.x
Description?	See below
Type?	bug fix
Category?	CO
BC breaks?	no
Deprecations?	no
How to test?	See below.
Fixed issue or discussion?	Fixes #27506, Fixes #33893
Related PRs
Sponsor company

Description

• This PR fixes unreliable logic when adding and deleting lang entries for objects.
• It fixes the need of using magically created primary keys when adding new entries and some weird select. Now it just selects data in default language and shop, cross joins ps_lang table and inserts ignore it back. It doesn't care about any columns and their order.
• It fixes a delete logic when there is a custom table that doesn't contain id_lang, it would throw an error. I added a check for this.
• It also fixes the same issue when adding a language. Before copying the data, we check if there is id_lang column.

How to test - 1

• Have 1 language.
• Have native GDPR module installed and see if there are some entries in ps_psgdpr_consent_lang.
• Add a new language and see that they are created for the new language you added.

How to test - 2

• Create a table ps_blabla_lang in phpmyadmin and put only test column there.
• Try to delete a language - will work fine.
• Try adding a language - will work fine.

Auto test

https://github.com/Hlavtox/ga.tests.ui.pr/actions/runs/6156328994

[prestonBot]

Hi, thanks for this contribution!

I found some issues with the Pull Request description:

• Your pull request does not seem to fix any issue, consider creating one (see note below) and linking it by writing Fixes #1234.

Would you mind having a look at it? This will help us understand how interesting your contribution is, thank you very much!

About linked issues

Please consider opening an issue before submitting a Pull Request:

• If it's a bug fix, it helps maintainers verify that the bug is effectively due to a defect in the code, and that it hasn't been fixed already.
• It can help trigger a discussion about the best implementation path before a single line of code is written.
• It may lead the Core Product team to mark that issue as a priority, further attracting the maintainers' attention.

(Note: this is an automated message, but answering it will reach a real human)

[M0rgan01]

Thanks for the comments, which helps to understand the code

[aniszr]

Hello @Hlavtox

I tested your PR and all improvements you'v mentioned in description are verified :

• 1st Improvement
  Afer adding a new language ps_psgdpr_consent_lang table is well updated by new entries from he added language

See attached screenshots:

• 2nd Improvement

Deleting and adding language works fine event with new table on database ps_blabla_lang for example.

Auto Test : https://github.com/Hlavtox/ga.tests.ui.pr/actions/runs/6156328994 ✔️
QA ✔️

[prestonBot]

QA approved, well done! Message to the maintainers: do not forget to milestone it before the merge.

[Hlavtox]

Thanks @aniszr! :-)