Functional Tests : BO - Catalog - Products : Pack Tab #33963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Progi1984
commented
Sep 18, 2023
•
Progi1984
commented
| Questions | Answers |
|---|---|
| Branch? | develop |
| Description? | Functional Tests : BO - Catalog - Products : Pack Tab |
| Type? | improvement |
| Category? | TE |
| BC breaks? | no |
| Deprecations? | no |
| How to test? | CI is 馃煝 |
| UI Tests | https://github.com/Progi1984/ga.tests.ui.pr/actions/runs/6223375149 |
| Fixed issue or discussion? | N/A |
| Related PRs | N/A |
| Sponsor company | @PrestaShopCorp |
Progi1984
force-pushed
the
test5211
branch
2 times, most recently
from
68db805
to
4c8a223
Compare
boubkerbribri
approved these changes
Sep 19, 2023
Comment on lines
+214
to
+216
| reference: (await page.locator(this.productHeaderReference('reference')).count()) | ||
| ? await this.getTextContent(page, this.productHeaderReference('reference'), false) | ||
| : '', |
There was a problem hiding this comment.
Maybe create specific functions for this one and others, so we could use individually ?
Comment on lines
+307
to
+308
| const createProductFrame: Frame | null = page.frame({url: /sell\/catalog\/products-v2\/create/gmi}); | ||
| expect(createProductFrame).to.be.not.eq(null); |
There was a problem hiding this comment.
expect should be removed from pages (I think it's a WIP on delete productV1)
nesrineabdmouleh
approved these changes
Sep 21, 2023
|
Thank you @Progi1984 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.