Fix WebProfiler when dev mode is active #33990
Merged
+80
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boherm
force-pushed
the
fix-web-profiler-in-devmode
branch
from
04ae4d5
to
38c10d7
Compare
M0rgan01
previously approved these changes
Sep 20, 2023
matthieu-rolland
previously approved these changes
Sep 20, 2023
boherm
dismissed stale reviews from matthieu-rolland and M0rgan01
via
f471c56
boherm
force-pushed
the
fix-web-profiler-in-devmode
branch
from
38c10d7
to
f471c56
Compare
matthieu-rolland
previously approved these changes
Sep 20, 2023
jolelievre
requested changes
Sep 20, 2023
boherm
force-pushed
the
fix-web-profiler-in-devmode
branch
from
f471c56
to
25eba1a
Compare
M0rgan01
approved these changes
Sep 21, 2023
jolelievre
approved these changes
Sep 25, 2023
ps-jarvis
added
the
Waiting for QA
matthieu-rolland
approved these changes
Sep 25, 2023
|
Hello @boherm Thank you for your PR, I tested it and it's seems to works as we can see : Untitled_.Sep.26.2023.3_19.PM.webmTest auto : https://github.com/AureRita/testing_pr/actions/runs/6313446206/job/17143680591 Test auto are green, so it's a QA ✔️ |
AureRita
approved these changes
Sep 26, 2023
AureRita
added
QA ✔️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
developbranch and since upgrade to symfony 5.ApplicationName and Version are deprecated in ConfigDataCollector.php since 4.2.
To fix this issue, we need to extend this collector and add PrestaShop version.
2. Click on
9.0.0at the bottom right of the debug bar.3. We have now a worked page in the profiler.
Before this fix:
Enregistrement.de.l.ecran.2023-09-20.a.15.34.38.mov
After this fix:
Enregistrement.de.l.ecran.2023-09-20.a.15.36.30.mov