Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wording fixed for final export for 8.1.2 #34018

Merged
merged 1 commit into from Sep 21, 2023

Conversation

jolelievre
Copy link
Contributor

@jolelievre jolelievre commented Sep 21, 2023

Questions Answers
Branch? 8.1.x
Description? Wording fixed for final export for 8.1.2
Type? bug fix
Category? IN
BC breaks? no
Deprecations? no
How to test? ~
UI Tests https://github.com/jolelievre/ga.tests.ui.pr/actions/runs/6260362015
Fixed issue or discussion? ~
Related PRs ~
Sponsor company ~

@jolelievre jolelievre requested a review from a team as a code owner September 21, 2023 10:10
@prestonBot
Copy link
Collaborator

Hi, thanks for this contribution!

I found some issues with the Pull Request description:

  • Your pull request does not seem to fix any issue, consider creating one (see note below) and linking it by writing Fixes #1234.

Would you mind having a look at it? This will help us understand how interesting your contribution is, thank you very much!

About linked issues

Please consider opening an issue before submitting a Pull Request:

  • If it's a bug fix, it helps maintainers verify that the bug is effectively due to a defect in the code, and that it hasn't been fixed already.
  • It can help trigger a discussion about the best implementation path before a single line of code is written.
  • It may lead the Core Product team to mark that issue as a priority, further attracting the maintainers' attention.

(Note: this is an automated message, but answering it will reach a real human)

@prestonBot prestonBot added 8.1.x Branch Bug fix Type: Bug fix labels Sep 21, 2023
@Julievrz Julievrz added the Wording ✔️ Status: check done, wording approved label Sep 21, 2023
@ps-jarvis ps-jarvis added the Waiting for QA Status: action required, waiting for test feedback label Sep 21, 2023
@matks matks removed the Waiting for QA Status: action required, waiting for test feedback label Sep 21, 2023
@matks
Copy link
Contributor

matks commented Sep 21, 2023

Thank you @jolelievre and @Julievrz

@matks matks merged commit ee1a686 into PrestaShop:8.1.x Sep 21, 2023
38 checks passed
@matks matks added this to the 8.1.2 milestone Sep 21, 2023
@jolelievre jolelievre deleted the wording-fixes branch February 1, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.1.x Branch Bug fix Type: Bug fix Wording ✔️ Status: check done, wording approved
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

7 participants