Add missing params doc for get method in Configuration.php #34056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
hugofintecture
commented
Sep 25, 2023
hugofintecture
commented
| Questions | Answers |
|---|---|
| Branch? | develop |
| Description? | Just add missing doc for some params |
| Type? | improvement |
| Category? | CO |
| BC breaks? | no |
| Deprecations? | no |
| How to test? | / |
| UI Tests | / |
| Fixed issue or discussion? | / |
| Related PRs | / |
| Sponsor company | Fintecture |
hugofintecture
force-pushed
the
patch-1
branch
from
d4ba92b
to
42a7883
Compare
matthieu-rolland
approved these changes
Sep 25, 2023
nicosomb
approved these changes
Sep 26, 2023
ps-jarvis
added
the
Waiting for QA
nicosomb
added
QA ✔️
|
Thank you @hugofintecture ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.