Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change prestashop.com to prestashop-project.org in .htaccess #34121

Merged
merged 2 commits into from Oct 4, 2023
Merged

Change prestashop.com to prestashop-project.org in .htaccess #34121

merged 2 commits into from Oct 4, 2023

Conversation

jf-viguier
Copy link
Contributor

Questions Answers
Branch? develop
Description? change prestashop.com to prestashop-project.org in .htaccess
Type? improvement
Category? FO
BC breaks? no
Deprecations? no
How to test? just a text
UI Tests no
Fixed issue or discussion? no
Sponsor company Creabilis

@jf-viguier jf-viguier requested a review from a team as a code owner October 2, 2023 08:02
@prestonBot prestonBot added develop Branch Improvement Type: Improvement labels Oct 2, 2023
nicosomb
nicosomb previously approved these changes Oct 2, 2023
View reviewed changes
@kpodemski kpodemski added Hacktoberfest Identify Hacktoberfest contributions and removed Hacktoberfest Identify Hacktoberfest contributions labels Oct 2, 2023
kpodemski
kpodemski previously approved these changes Oct 2, 2023
View reviewed changes
@ps-jarvis ps-jarvis added the Waiting for QA Status: action required, waiting for test feedback label Oct 2, 2023
@kpodemski kpodemski removed the Waiting for QA Status: action required, waiting for test feedback label Oct 2, 2023
@kpodemski
Copy link
Contributor

To be merged after the tests.

matks
matks reviewed Oct 2, 2023
View reviewed changes
Copy link
Contributor

@matks matks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jf-viguier I think you can also modify lines 2110 and 2370 to make this change relevant 😉 let's change it uniformly

@matks matks changed the title change prestashop.com to prestashop-project.org in .htaccess Change prestashop.com to prestashop-project.org in .htaccess Oct 2, 2023
@nicosomb
Copy link
Contributor

nicosomb commented Oct 2, 2023

I think you can also modify lines 2110 and 2370 to make this change relevant 😉 let's change it uniformly

Or you can open 2 other PR for Hacktoberfest :trollface: 😅😘

@jf-viguier jf-viguier dismissed stale reviews from kpodemski and nicosomb via e126f27 October 2, 2023 12:04
@jf-viguier
Copy link
Contributor Author

@matks 2370 changed, nice catch.
For line 2110 no, it's for retrocompatibility before start stuff.

@ps-jarvis ps-jarvis added the Waiting for QA Status: action required, waiting for test feedback label Oct 2, 2023
@matks
Copy link
Contributor

matks commented Oct 3, 2023

@jf-viguier Can you please describe more how to test? 😉

@jf-viguier
Copy link
Contributor Author

@matks it's just a text comment, nothing to test. I don't understand.
The replace stuff before the start is for an unsupported prestashop version I guess : 1.5 ou 1.6 ? I don't know

@paulnoelcholot
Copy link

Hello @jf-viguier,

I tested your PR and it's GOOD for me! 🎉

Thanks!

@paulnoelcholot paulnoelcholot added QA ✔️ Status: check done, code approved and removed Waiting for QA Status: action required, waiting for test feedback labels Oct 4, 2023
@prestonBot
Copy link
Collaborator

QA approved, well done! Message to the maintainers: do not forget to milestone it before the merge.

@ps-jarvis ps-jarvis added the Waiting for QA Status: action required, waiting for test feedback label Oct 4, 2023
@paulnoelcholot paulnoelcholot removed the Waiting for QA Status: action required, waiting for test feedback label Oct 4, 2023
@boherm boherm merged commit a4f902a into PrestaShop:develop Oct 4, 2023
18 checks passed
@boherm
Copy link
Member

boherm commented Oct 4, 2023

Thanks @jf-viguier!

@matks
Copy link
Contributor

matks commented Oct 4, 2023

@boherm Don't forget the milestone 😉

@matks matks added this to the 9.0.0 milestone Oct 4, 2023
@boherm
Copy link
Member

boherm commented Oct 4, 2023

Oopsi! @matks nice catch 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matks matks matks left review comments

@nicosomb nicosomb nicosomb approved these changes

@boherm boherm boherm approved these changes

@paulnoelcholot paulnoelcholot paulnoelcholot approved these changes

@kpodemski kpodemski kpodemski left review comments

Assignees
No one assigned
Labels
develop Branch Improvement Type: Improvement QA ✔️ Status: check done, code approved
Projects
PR Dashboard
Archived in project
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@jf-viguier @kpodemski @nicosomb @matks @paulnoelcholot @prestonBot @boherm @ps-jarvis