Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing hook actionSubmitAccountBefore #34133

Merged
merged 1 commit into from Oct 4, 2023

Conversation

jf-viguier
Copy link
Contributor

@jf-viguier jf-viguier commented Oct 2, 2023

Questions Answers
Branch? develop
Description? add missing hook actionSubmitAccountBefore
Type? bug fix
Category? FO
BC breaks? no
Deprecations? no
How to test? missing hook at install in hook table
Fixed issue or discussion? Fixes #34134
Sponsor company Creabilis

@jf-viguier jf-viguier requested a review from a team as a code owner October 2, 2023 15:11
@prestonBot
Copy link
Collaborator

Hi, thanks for this contribution!

I found some issues with the Pull Request description:

  • Your pull request does not seem to fix any issue, consider creating one (see note below) and linking it by writing Fixes #1234.

Would you mind having a look at it? This will help us understand how interesting your contribution is, thank you very much!

About linked issues

Please consider opening an issue before submitting a Pull Request:

  • If it's a bug fix, it helps maintainers verify that the bug is effectively due to a defect in the code, and that it hasn't been fixed already.
  • It can help trigger a discussion about the best implementation path before a single line of code is written.
  • It may lead the Core Product team to mark that issue as a priority, further attracting the maintainers' attention.

(Note: this is an automated message, but answering it will reach a real human)

@prestonBot prestonBot added develop Branch Bug fix Type: Bug fix labels Oct 2, 2023
@ghost
Copy link

ghost commented Oct 3, 2023

Nice catch You should also add it to autoupgrade

@ps-jarvis ps-jarvis added the Waiting for QA Status: action required, waiting for test feedback label Oct 4, 2023
Copy link
Contributor

@florine2623 florine2623 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @jf-viguier ,

The missing hook is now present :
Screenshot 2023-10-04 at 15 42 10

QA ✅
Thanks!

@florine2623 florine2623 self-assigned this Oct 4, 2023
@florine2623 florine2623 added QA ✔️ Status: check done, code approved and removed Waiting for QA Status: action required, waiting for test feedback labels Oct 4, 2023
@prestonBot
Copy link
Collaborator

QA approved, well done! Message to the maintainers: do not forget to milestone it before the merge.

@boherm boherm merged commit 442f129 into PrestaShop:develop Oct 4, 2023
18 checks passed
@boherm
Copy link
Member

boherm commented Oct 4, 2023

Thanks @jf-viguier!
@nicosomb, the actionSubmitAccountBefore hook seems to be already in the autoupgrade module, no?

@matks matks changed the title add missing hook actionSubmitAccountBefore Add missing hook actionSubmitAccountBefore Oct 9, 2023
@matks
Copy link
Contributor

matks commented Oct 9, 2023

@boherm Don't forget the milestone 😉

@matks matks added this to the 9.0.0 milestone Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug fix Type: Bug fix develop Branch Needs autoupgrade PR QA ✔️ Status: check done, code approved
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

missing hook actionSubmitAccountBefore
8 participants