New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing hook actionSubmitAccountBefore #34133
Conversation
jf-viguier
commented
Oct 2, 2023
•
edited
edited
Questions | Answers |
---|---|
Branch? | develop |
Description? | add missing hook actionSubmitAccountBefore |
Type? | bug fix |
Category? | FO |
BC breaks? | no |
Deprecations? | no |
How to test? | missing hook at install in hook table |
Fixed issue or discussion? | Fixes #34134 |
Sponsor company | Creabilis |
Hi, thanks for this contribution! I found some issues with the Pull Request description:
Would you mind having a look at it? This will help us understand how interesting your contribution is, thank you very much! About linked issuesPlease consider opening an issue before submitting a Pull Request:
(Note: this is an automated message, but answering it will reach a real human) |
Nice catch You should also add it to autoupgrade |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
QA approved, well done! Message to the maintainers: do not forget to milestone it before the merge. |
Thanks @jf-viguier! |
@boherm Don't forget the milestone 😉 |