Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create API Access page with grid and basic form #34149

Merged
merged 9 commits into from Oct 4, 2023

Conversation

jolelievre
Copy link
Contributor

@jolelievre jolelievre commented Oct 3, 2023

Questions Answers
Branch? develop
Description? Create grid and form for Api access, only limited to four fields for now.
Type? new feature
Category? BO
BC breaks? no
Deprecations? no
How to test? CI green and UI tests green
UI Tests https://github.com/jolelievre/ga.tests.ui.pr/actions/runs/6404142884
Fixed issue or discussion? Fixes #33767
Related PRs ~
Sponsor company ~

@prestonBot
Copy link
Collaborator

Hi, thanks for this contribution!

I found some issues with the Pull Request description:

  • Your pull request does not seem to fix any issue, consider creating one (see note below) and linking it by writing Fixes #1234.

Would you mind having a look at it? This will help us understand how interesting your contribution is, thank you very much!

About linked issues

Please consider opening an issue before submitting a Pull Request:

  • If it's a bug fix, it helps maintainers verify that the bug is effectively due to a defect in the code, and that it hasn't been fixed already.
  • It can help trigger a discussion about the best implementation path before a single line of code is written.
  • It may lead the Core Product team to mark that issue as a priority, further attracting the maintainers' attention.

(Note: this is an automated message, but answering it will reach a real human)

@prestonBot prestonBot added develop Branch Feature Type: New Feature labels Oct 3, 2023
@jolelievre jolelievre changed the title Introduce form data provider and form data handler for ApiAccess form Create API Access page with grid and basic form Oct 3, 2023
@jolelievre jolelievre marked this pull request as ready for review October 3, 2023 19:07
@jolelievre jolelievre requested review from a team as code owners October 3, 2023 19:07
Copy link
Contributor

@matks matks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat 🤌

@jolelievre jolelievre merged commit b03f6eb into PrestaShop:develop Oct 4, 2023
26 of 27 checks passed
@jolelievre jolelievre deleted the api-access-simple-form branch October 4, 2023 13:39
@matks matks added this to the 9.0.0 milestone Oct 9, 2023
@matks
Copy link
Contributor

matks commented Oct 9, 2023

@jolelievre Don't forget the milestone 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
develop Branch Feature Type: New Feature
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Integrate Api access list and form with simple fields (only first three)
7 participants