Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Functional Tests : Removed Product Page v1 #34237

Merged
merged 1 commit into from Oct 19, 2023
Merged

Functional Tests : Removed Product Page v1 #34237

merged 1 commit into from Oct 19, 2023

Conversation

Progi1984
Copy link
Contributor

@Progi1984 Progi1984 commented Oct 10, 2023 •
edited

Questions Answers
Branch? develop
Description? Functional Tests : Removed Product Page v1
Type? bug fix
Category? TE
BC breaks? no
Deprecations? no
How to test? CI is 馃煝
UI Tests https://github.com/Progi1984/ga.tests.ui.pr/actions/runs/6531460313
https://github.com/Progi1984/ga.tests.ui.pr/actions/runs/6535206029
Fixed issue or discussion? N/A
Related PRs N/A
Sponsor company @PrestaShopCorp

Linked PRs :

@Progi1984 Progi1984 added TE Category: Tests E2E Tests labels Oct 10, 2023
@Progi1984 Progi1984 added this to the 9.0.0 milestone Oct 10, 2023
@prestonBot prestonBot added develop Branch Bug fix Type: Bug fix labels Oct 10, 2023
@Progi1984 Progi1984 force-pushed the byeByePPV1 branch 24 times, most recently from e5540b5 to 7f08fad Compare October 16, 2023 13:13
@Progi1984 Progi1984 marked this pull request as ready for review October 16, 2023 15:33
@Progi1984 Progi1984 requested review from a team as code owners October 16, 2023 15:33
nicosomb
nicosomb approved these changes Oct 17, 2023
View reviewed changes
Copy link
Contributor

@nicosomb nicosomb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK for the github action part.

boubkerbribri
boubkerbribri reviewed Oct 19, 2023
View reviewed changes
Copy link
Contributor

@boubkerbribri boubkerbribri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Little suggestion but LGTM.

tests/UI/pages/BO/catalog/products/add/stocksTab.ts Show resolved Hide resolved
@boubkerbribri boubkerbribri merged commit ef067b2 into PrestaShop:develop Oct 19, 2023
24 of 27 checks passed
@boubkerbribri boubkerbribri added the QA 鉁旓笍 Status: check done, code approved label Oct 19, 2023
@Progi1984 Progi1984 deleted the byeByePPV1 branch October 19, 2023 09:25
@boubkerbribri
Copy link
Contributor

Thanks @Progi1984

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicosomb nicosomb nicosomb approved these changes

@nesrineabdmouleh nesrineabdmouleh nesrineabdmouleh approved these changes

@boubkerbribri boubkerbribri boubkerbribri approved these changes

Assignees
No one assigned
Labels
Bug fix Type: Bug fix develop Branch E2E Tests QA 鉁旓笍 Status: check done, code approved TE Category: Tests
Projects
PR Dashboard
Archived in project
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Progi1984 @boubkerbribri @nicosomb @nesrineabdmouleh @prestonBot