Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve installation language fallback system #34241

Merged

Conversation

jolelievre
Copy link
Contributor

@jolelievre jolelievre commented Oct 11, 2023

Questions Answers
Branch? develop
Description? In installation from browser the fallback when HTTP_ACCEPT_LANGUAGE was not set did not work properly, this is fixed so that we can curl the page correctly in CI workflows
Type? bug fix
Category? IN
BC breaks? no
Deprecations? no
How to test? CI green and UI tests green
UI Tests https://github.com/jolelievre/ga.tests.ui.pr/actions/runs/6480520412
Fixed issue or discussion? ~
Related PRs ~
Sponsor company @PrestaShopCorp

…as not set did not work properly, this is fixed so that we can curl the page correctly in CI workflows
@jolelievre jolelievre requested a review from a team as a code owner October 11, 2023 09:17
@prestonBot
Copy link
Collaborator

Hi, thanks for this contribution!

I found some issues with the Pull Request description:

  • Your pull request does not seem to fix any issue, consider creating one (see note below) and linking it by writing Fixes #1234.

Would you mind having a look at it? This will help us understand how interesting your contribution is, thank you very much!

About linked issues

Please consider opening an issue before submitting a Pull Request:

  • If it's a bug fix, it helps maintainers verify that the bug is effectively due to a defect in the code, and that it hasn't been fixed already.
  • It can help trigger a discussion about the best implementation path before a single line of code is written.
  • It may lead the Core Product team to mark that issue as a priority, further attracting the maintainers' attention.

(Note: this is an automated message, but answering it will reach a real human)

@prestonBot prestonBot added develop Branch Bug fix Type: Bug fix labels Oct 11, 2023
@ps-jarvis ps-jarvis added the Waiting for QA Status: action required, waiting for test feedback label Oct 11, 2023
@florine2623
Copy link
Contributor

@jolelievre , could you relaunch the failed tests please ?
Other than auto tests, there's nothing to test by QA ?

@florine2623 florine2623 added the Waiting for author Status: action required, waiting for author feedback label Oct 11, 2023
@Progi1984
Copy link
Contributor

@florine2623 No need. We (me and @boubkerbribri) have participed to the PR for validation.

@Progi1984 Progi1984 removed the Waiting for author Status: action required, waiting for author feedback label Oct 12, 2023
@Progi1984
Copy link
Contributor

@florine2623 : @jolelievre restarted its tests. It's ok.

@florine2623 florine2623 added QA ✔️ Status: check done, code approved and removed Waiting for QA Status: action required, waiting for test feedback labels Oct 12, 2023
@prestonBot
Copy link
Collaborator

QA approved, well done! Message to the maintainers: do not forget to milestone it before the merge.

@florine2623
Copy link
Contributor

Thanks @Progi1984 and @jolelievre ! OK to merge

@Progi1984 Progi1984 added this to the 9.0.0 milestone Oct 12, 2023
@kpodemski kpodemski merged commit 3e559f4 into PrestaShop:develop Oct 12, 2023
18 checks passed
@jolelievre jolelievre deleted the fix-install-language-fallback branch February 1, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug fix Type: Bug fix develop Branch QA ✔️ Status: check done, code approved
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

9 participants