New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve installation language fallback system #34241
Improve installation language fallback system #34241
Conversation
jolelievre
commented
Oct 11, 2023
•
edited
edited
Questions | Answers |
---|---|
Branch? | develop |
Description? | In installation from browser the fallback when HTTP_ACCEPT_LANGUAGE was not set did not work properly, this is fixed so that we can curl the page correctly in CI workflows |
Type? | bug fix |
Category? | IN |
BC breaks? | no |
Deprecations? | no |
How to test? | CI green and UI tests green |
UI Tests | https://github.com/jolelievre/ga.tests.ui.pr/actions/runs/6480520412 |
Fixed issue or discussion? | ~ |
Related PRs | ~ |
Sponsor company | @PrestaShopCorp |
…as not set did not work properly, this is fixed so that we can curl the page correctly in CI workflows
Hi, thanks for this contribution! I found some issues with the Pull Request description:
Would you mind having a look at it? This will help us understand how interesting your contribution is, thank you very much! About linked issuesPlease consider opening an issue before submitting a Pull Request:
(Note: this is an automated message, but answering it will reach a real human) |
@jolelievre , could you relaunch the failed tests please ? |
@florine2623 No need. We (me and @boubkerbribri) have participed to the PR for validation. |
@florine2623 : @jolelievre restarted its tests. It's ok. |
QA approved, well done! Message to the maintainers: do not forget to milestone it before the merge. |
Thanks @Progi1984 and @jolelievre ! OK to merge |