Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove historic tabs system #34290

Merged
merged 1 commit into from Oct 17, 2023
Merged

Remove historic tabs system #34290

merged 1 commit into from Oct 17, 2023

Conversation

Hlavtox
Copy link
Contributor

@Hlavtox Hlavtox commented Oct 16, 2023 •
edited by M0rgan01

Questions Answers
Branch? develop
Description? Removes old unused way of creating tabs in BO.
Type? refacto
Category? BO
BC breaks? yes
Deprecations? no
How to test? Tests green.
UI Tests https://github.com/M0rgan01/ga.tests.ui.pr/actions/runs/6534381234
Fixed issue or discussion?
Related PRs
Sponsor company

@Hlavtox Hlavtox requested a review from a team as a code owner October 16, 2023 11:25
@prestonBot prestonBot added develop Branch Refactoring Type: Refactoring BC break Type: Introduces a backwards-incompatible break labels Oct 16, 2023
@ps-jarvis ps-jarvis added the Waiting for QA Status: action required, waiting for test feedback label Oct 16, 2023
@kpodemski
Copy link
Contributor

@PrestaShop/qa-functional since the autotests and CI are green, we would like to merge the PR, can we? :)

@Robin-Fischer-PS
Copy link
Contributor

Yep, looks fine to me. Thanks @Hlavtox for the PR !

@Robin-Fischer-PS Robin-Fischer-PS merged commit 6483032 into PrestaShop:develop Oct 17, 2023
18 checks passed
@Progi1984 Progi1984 added this to the 9.0.0 milestone Oct 17, 2023
@Hlavtox Hlavtox deleted the remove-old-tab branch October 18, 2023 13:13
@kpodemski kpodemski removed the Waiting for QA Status: action required, waiting for test feedback label Nov 6, 2023
@Hlavtox Hlavtox restored the remove-old-tab branch November 10, 2023 15:53
@Hlavtox Hlavtox deleted the remove-old-tab branch November 10, 2023 15:53
@Hlavtox Hlavtox mentioned this pull request Nov 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kpodemski kpodemski kpodemski approved these changes

@M0rgan01 M0rgan01 M0rgan01 approved these changes

Assignees
No one assigned
Labels
BC break Type: Introduces a backwards-incompatible break develop Branch Refactoring Type: Refactoring
Projects
PR Dashboard
Archived in project
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@Hlavtox @kpodemski @Robin-Fischer-PS @M0rgan01 @Progi1984 @ps-jarvis @prestonBot