Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ButtonCollectionType groups splitting #34305

Merged

Conversation

jolelievre
Copy link
Contributor

Questions Answers
Branch? develop
Description? Fix ButtonCollectionType groups splitting that was broken by inline_buttons_limit feature, the children were rendered multiple times so not displayed in the appropriate group div But more important in recent Symfony version a form cannot be rendered twice and hat used to fail silently now shouts about it (which is a good thing)
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
How to test? See issue #34197
UI Tests
Fixed issue or discussion? Fixes #34197
Related PRs ~
Sponsor company ~

@jolelievre jolelievre requested a review from a team as a code owner October 16, 2023 17:48
@prestonBot
Copy link
Collaborator

Hi, thanks for this contribution!

I found some issues with the Pull Request description:

  • Your pull request does not seem to fix any issue, consider creating one (see note below) and linking it by writing Fixes #1234.

Would you mind having a look at it? This will help us understand how interesting your contribution is, thank you very much!

About linked issues

Please consider opening an issue before submitting a Pull Request:

  • If it's a bug fix, it helps maintainers verify that the bug is effectively due to a defect in the code, and that it hasn't been fixed already.
  • It can help trigger a discussion about the best implementation path before a single line of code is written.
  • It may lead the Core Product team to mark that issue as a priority, further attracting the maintainers' attention.

(Note: this is an automated message, but answering it will reach a real human)

@prestonBot prestonBot added develop Branch Bug fix Type: Bug fix labels Oct 16, 2023
@jolelievre jolelievre changed the title Fix ButtonCollectionType groups splitting that was broken by inline_b… Fix ButtonCollectionType groups splitting Oct 16, 2023
@ps-jarvis ps-jarvis added the Waiting for QA Status: action required, waiting for test feedback label Oct 17, 2023
@florine2623 florine2623 self-assigned this Oct 19, 2023
Copy link
Contributor

@florine2623 florine2623 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @jolelievre ,

Test autos OK : https://github.com/florine2623/testing_pr/actions/runs/6572288276

Tested the standard case.
Checked the following :

  • standard case with multigroup shops
  • duplicate product
  • switch from shop to shop using Select Store button + shop banner

QA OK ✅

@florine2623 florine2623 added QA ✔️ Status: check done, code approved and removed Waiting for QA Status: action required, waiting for test feedback labels Oct 19, 2023
@prestonBot
Copy link
Collaborator

QA approved, well done! Message to the maintainers: do not forget to milestone it before the merge.

@Progi1984 Progi1984 added this to the 9.0.0 milestone Oct 19, 2023
@nicosomb nicosomb merged commit cf52771 into PrestaShop:develop Oct 19, 2023
18 checks passed
@jolelievre jolelievre deleted the fix-collection-button-groups branch February 1, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug fix Type: Bug fix develop Branch QA ✔️ Status: check done, code approved
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

PPV2 - multistore - Exception is displayed when I change my context shop while editing a product
9 participants