New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ButtonCollectionType groups splitting #34305
Fix ButtonCollectionType groups splitting #34305
Conversation
jolelievre
commented
Oct 16, 2023
Questions | Answers |
---|---|
Branch? | develop |
Description? | Fix ButtonCollectionType groups splitting that was broken by inline_buttons_limit feature, the children were rendered multiple times so not displayed in the appropriate group div But more important in recent Symfony version a form cannot be rendered twice and hat used to fail silently now shouts about it (which is a good thing) |
Type? | bug fix |
Category? | BO |
BC breaks? | no |
Deprecations? | no |
How to test? | See issue #34197 |
UI Tests | |
Fixed issue or discussion? | Fixes #34197 |
Related PRs | ~ |
Sponsor company | ~ |
…uttons_limit feature
Hi, thanks for this contribution! I found some issues with the Pull Request description:
Would you mind having a look at it? This will help us understand how interesting your contribution is, thank you very much! About linked issuesPlease consider opening an issue before submitting a Pull Request:
(Note: this is an automated message, but answering it will reach a real human) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @jolelievre ,
Test autos OK : https://github.com/florine2623/testing_pr/actions/runs/6572288276
Tested the standard case.
Checked the following :
- standard case with multigroup shops
- duplicate product
- switch from shop to shop using Select Store button + shop banner
QA OK ✅
QA approved, well done! Message to the maintainers: do not forget to milestone it before the merge. |