Fix potential TypeError in ProductLazyArray.php

[hugofintecture]

Questions	Answers
Branch?	develop
Description?	See bellow
Type?	bug fix
Category?	FO
BC breaks?	no
Deprecations?	no
How to test?	See bellow.
UI Tests
Fixed issue or discussion?	Fixes #34483
Related PRs	N/A
Sponsor company	Fintecture

Fix: Fatal error: Uncaught TypeError: reset(): ProductLazyArray.php(564)

When switch from French to English gb in the order confirmation page we have this error:

Don't know if it's normal to receive a string however but at least it don't break the page :)

I tried to print all values with this code in the function to find the responsible value:

echo '<pre>';
var_dump($this->product['attributes']);
echo '</pre>';

And here's the problematic string:

string(9) "Taille: S"

[boherm]

Thanks for your contribution @hugofintecture 😉

[Hlavtox]

@hugofintecture Nice catch Hugo! I checked the code and the issue happens because ProductLazyArray can be inflated by two data sources.

Normally, attributes contains Product::getAttributesParams -

PrestaShop/classes/Product.php

Line 5740 in df3d44c

$attributes = Product::getAttributesParams($row['id_product'], $row['id_product_attribute']);

But in context of a cart, it's a string of joined attributes -

PrestaShop/classes/Cart.php

Line 959 in df3d44c

self::$_attributesLists[$productAttributeKey] ?? self::DEFAULT_ATTRIBUTES_KEYS

Not sure how to fix it safely...

[florine2623]

Hello @hugofintecture ,

I can't reproduce your issue without the PR.

Screen.Recording.2023-11-03.at.14.25.49.mov

Normally you should have created an issue before so we can validate it before creating a PR to fix it ^^

[Hlavtox]

Hi, @AureRita just reproduced here - #34483, can you do the QA?
Not sure why @florine2623 didn't reproduce. 🤔 Maybe this code issue is fatal only on develop?

This definitely is a working fix however. :-)

[florine2623]

It is QA ✅

Before :

After :

Screen.Recording.2023-11-06.at.16.30.21.mov

Tested with other languages as well, works as expected.

Thanks 💪

[prestonBot]

QA approved, well done! Message to the maintainers: do not forget to milestone it before the merge.

[Hlavtox]

All good! Merging, thanks everyone