Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing js events in CleanHtmlValidator #34377

Merged
merged 1 commit into from Oct 25, 2023
Merged

Add missing js events in CleanHtmlValidator #34377

merged 1 commit into from Oct 25, 2023

Conversation

matthieu-rolland
Copy link
Contributor

@matthieu-rolland matthieu-rolland commented Oct 24, 2023 •
edited

Questions Answers
Branch? 8.1.x
Description? add missing js events in CleanHtmlValidator
Type? improvement
Category? CO
BC breaks? no
Deprecations? no
How to test? CI green
UI Tests https://github.com/matthieu-rolland/ga.tests.ui.pr/actions/runs/6629335281
Fixed issue or discussion? none
Related PRs none
Sponsor company PrestaShop

@matthieu-rolland matthieu-rolland requested a review from a team as a code owner October 24, 2023 15:47
@prestonBot prestonBot added 8.1.x Branch Improvement Type: Improvement labels Oct 24, 2023
@ps-jarvis ps-jarvis added the Waiting for QA Status: action required, waiting for test feedback label Oct 24, 2023
@matks matks changed the title add missing js events in CleanHtmlValidator Add missing js events in CleanHtmlValidator Oct 25, 2023
AureRita
AureRita approved these changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@AureRita AureRita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @matthieu-rolland

As the auto test is 🟢 , it's a QA Approved ✔️

Thank you

@AureRita AureRita added QA ✔️ Status: check done, code approved and removed Waiting for QA Status: action required, waiting for test feedback labels Oct 25, 2023
@prestonBot
Copy link
Collaborator

QA approved, well done! Message to the maintainers: do not forget to milestone it before the merge.

@mflasquin
Copy link
Contributor

thanks @matthieu-rolland !

@mflasquin mflasquin merged commit c841d76 into PrestaShop:8.1.x Oct 25, 2023
38 checks passed
@nicosomb nicosomb added this to the 8.1.3 milestone Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matks matks matks approved these changes

@tleon tleon tleon approved these changes

@jolelievre jolelievre jolelievre approved these changes

@boherm boherm boherm approved these changes

@M0rgan01 M0rgan01 M0rgan01 approved these changes

@AureRita AureRita AureRita approved these changes

Assignees
No one assigned
Labels
8.1.x Branch Improvement Type: Improvement QA ✔️ Status: check done, code approved
Projects
PR Dashboard
Archived in project
Milestone
8.1.3
Development

Successfully merging this pull request may close these issues.

None yet