Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the � from the invalid character #34396

Merged
merged 1 commit into from Oct 27, 2023
Merged

Remove the � from the invalid character #34396

merged 1 commit into from Oct 27, 2023

Conversation

AureRita
Copy link
Contributor

@AureRita AureRita commented Oct 26, 2023 •
edited

Questions Answers
Branch? develop
Description? Currently, when we have the character "�" it means we have an unknown character, that's a little bit strange for a hint
Type? improvement
Category? BO
BC breaks? no
Deprecations? no
How to test? Go to BO > Sell > Customers > Adresses / Clic on Edit next to a Customer / Verify that you'll not have this icon
UI Tests https://github.com/AureRita/testing_pr/actions/runs/6656288138
Fixed issue or discussion?
Related PRs
Sponsor company PrestaShop

@AureRita AureRita requested a review from a team as a code owner October 26, 2023 15:22
@prestonBot
Copy link
Collaborator

Hello @AureRita!

This is your first pull request on the PrestaShop project. Thank you, and welcome to this Open Source community!

@prestonBot prestonBot added develop Branch Improvement Type: Improvement labels Oct 26, 2023
@AureRita AureRita added the Waiting for QA Status: action required, waiting for test feedback label Oct 27, 2023
@florine2623 florine2623 self-assigned this Oct 27, 2023
florine2623
florine2623 approved these changes Oct 27, 2023
View reviewed changes
Copy link
Contributor

@florine2623 florine2623 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @AureRita ,

It is QA ✅
Screenshot 2023-10-27 at 14 26 51

@florine2623 florine2623 added QA ✔️ Status: check done, code approved and removed Waiting for QA Status: action required, waiting for test feedback labels Oct 27, 2023
@prestonBot
Copy link
Collaborator

QA approved, well done! Message to the maintainers: do not forget to milestone it before the merge.

@nicosomb nicosomb merged commit 538124d into PrestaShop:develop Oct 27, 2023
18 checks passed
@nicosomb
Copy link
Contributor

Thank you @AureRita and @florine2623 !

@AureRita AureRita deleted the Remove-the-�-from-the-invalid-character branch October 27, 2023 13:13
@nicosomb nicosomb added this to the 9.0.0 milestone Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicosomb nicosomb nicosomb approved these changes

@matthieu-rolland matthieu-rolland matthieu-rolland approved these changes

@tleon tleon tleon approved these changes

@florine2623 florine2623 florine2623 approved these changes

@M0rgan01 M0rgan01 M0rgan01 approved these changes

Assignees

@florine2623 florine2623

Labels
develop Branch Improvement Type: Improvement QA ✔️ Status: check done, code approved
Projects
PR Dashboard
Archived in project
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@AureRita @prestonBot @nicosomb @matthieu-rolland @tleon @florine2623 @M0rgan01