Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Functional tests - Refacto 'BO > International > Translations' tests #34502

Merged
merged 4 commits into from Nov 10, 2023
Merged

Functional tests - Refacto 'BO > International > Translations' tests #34502

merged 4 commits into from Nov 10, 2023

Conversation

nesrineabdmouleh
Copy link
Contributor

@nesrineabdmouleh nesrineabdmouleh commented Nov 8, 2023 •
edited

Questions Answers
Branch? develop
Description? Refacto 'BO > International > Translations' tests
Type? refacto
Category? TE
BC breaks? no
Deprecations? no
How to test? CI and nightly are 馃挌
UI Tests https://github.com/nesrineabdmouleh/testing_pr/actions/runs/6814673239
Fixed issue or discussion? no
Related PRs no
Sponsor company

@nesrineabdmouleh nesrineabdmouleh added TE Category: Tests E2E Tests labels Nov 8, 2023
@nesrineabdmouleh nesrineabdmouleh added this to the 9.0.0 milestone Nov 8, 2023
@prestonBot prestonBot added develop Branch Refactoring Type: Refactoring labels Nov 8, 2023
@nesrineabdmouleh nesrineabdmouleh marked this pull request as ready for review November 8, 2023 13:48
@nesrineabdmouleh nesrineabdmouleh requested a review from a team as a code owner November 8, 2023 13:48
Progi1984
Progi1984 reviewed Nov 8, 2023
View reviewed changes
Copy link
Contributor

@Progi1984 Progi1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A small feedback

@Progi1984 Progi1984 added the QA 鉁旓笍 Status: check done, code approved label Nov 10, 2023
@nicosomb nicosomb merged commit dd7c149 into PrestaShop:develop Nov 10, 2023
22 of 24 checks passed
@nicosomb
Copy link
Contributor

Thank you @nesrineabdmouleh and @Progi1984 !

@nesrineabdmouleh nesrineabdmouleh deleted the TEST-1034 branch November 10, 2023 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Progi1984 Progi1984 Progi1984 approved these changes

@boubkerbribri boubkerbribri boubkerbribri approved these changes

Assignees
No one assigned
Labels
develop Branch E2E Tests QA 鉁旓笍 Status: check done, code approved Refactoring Type: Refactoring TE Category: Tests
Projects
PR Dashboard
Archived in project
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@nesrineabdmouleh @nicosomb @Progi1984 @boubkerbribri @prestonBot