Upgrade symfony http-kernel to 5.4.31 #34524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Hlavtox
commented
Nov 10, 2023
•
Hlavtox
commented
| Questions | Answers |
|---|---|
| Branch? | develop |
| Description? | My dear friend @ShaiMagal made sure that putenv no longer throws an error on public hostings in symfony/symfony#52428, this allows to benefit from it. |
| Type? | refacto |
| Category? | CO |
| BC breaks? | no |
| Deprecations? | no |
| How to test? | |
| UI Tests | https://github.com/Hlavtox/ga.tests.ui.pr/actions/runs/6827395441 |
| Fixed issue or discussion? | |
| Related PRs | |
| Sponsor company |
|
👍 but there is a cron for that, right? |
|
@nicosomb I am not sure, why we would still be on 5.4.23 then? |
|
The release is just some hours ago so the cron has simply not run yet |
|
@matks Ok, so why we are not on 5.4.30 that was released 2 weeks ago? :D https://github.com/symfony/http-kernel/releases/tag/v5.4.30 |
matks
approved these changes
Nov 10, 2023
ShaiMagal
approved these changes
Nov 10, 2023
nicosomb
approved these changes
Nov 11, 2023
There was a problem hiding this comment.
OK for me. As discussed with @Progi1984 and @matthieu-rolland, this kind of pull request should be handled by dependabot.
|
@Hlavtox could you restart the failing tests please? |
|
@nicosomb Done, only failing tests are with some wishlist, but I test it locally and everything works, no errors, no notices, so probably a false alarm. |
Hlavtox
added
the
Waiting for QA
ShaiMagal
approved these changes
Nov 11, 2023
M0rgan01
approved these changes
Nov 13, 2023
nicosomb
added
QA ✔️
|
Thank you @Hlavtox and @nesrineabdmouleh ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.