Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Address.php - small phpdoc edit (@return value) #34531

Merged
merged 1 commit into from Nov 12, 2023
Merged

Update Address.php - small phpdoc edit (@return value) #34531

merged 1 commit into from Nov 12, 2023

Conversation

ShaiMagal
Copy link
Contributor

Questions Answers
Branch? 8.1.x
Description? phpdoc is refering to @return array, but there can be returned bool as well (if $id_address is 0). So, fixing phpdoc @return value. Only small phpdoc change. Nothing else.
Type? refacto
Category? CO
BC breaks? no
Deprecations? no
How to test?
UI Tests
Fixed issue or discussion?
Related PRs
Sponsor company https://www.openservis.cz/

@ShaiMagal ShaiMagal requested a review from a team as a code owner November 11, 2023 11:58
@prestonBot prestonBot added 8.1.x Branch Refactoring Type: Refactoring labels Nov 11, 2023
Hlavtox
Hlavtox approved these changes Nov 11, 2023
View reviewed changes
Copy link
Contributor

@Hlavtox Hlavtox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No QA needed here, the next person can merge.

@ps-jarvis ps-jarvis added the Waiting for QA Status: action required, waiting for test feedback label Nov 12, 2023
@nicosomb nicosomb added QA ✔️ Status: check done, code approved and removed Waiting for QA Status: action required, waiting for test feedback labels Nov 12, 2023
@prestonBot
Copy link
Collaborator

QA approved, well done! Message to the maintainers: do not forget to milestone it before the merge.

@nicosomb nicosomb added this to the 8.1.3 milestone Nov 12, 2023
@nicosomb nicosomb merged commit 66ea8dc into PrestaShop:8.1.x Nov 12, 2023
38 checks passed
@ShaiMagal ShaiMagal deleted the getCountryAndState-small-phpdoc-fix branch November 12, 2023 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicosomb nicosomb nicosomb approved these changes

@Hlavtox Hlavtox Hlavtox approved these changes

Assignees
No one assigned
Labels
8.1.x Branch QA ✔️ Status: check done, code approved Refactoring Type: Refactoring
Projects
PR Dashboard
Archived in project
Milestone
8.1.3
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ShaiMagal @prestonBot @nicosomb @Hlavtox @ps-jarvis