Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Functional tests - Add new test 'Shop parameters > Enable/Disable iframes' #34573

Merged
merged 2 commits into from Nov 16, 2023

Conversation

nesrineabdmouleh
Copy link
Contributor

@nesrineabdmouleh nesrineabdmouleh commented Nov 15, 2023

Questions Answers
Branch? develop
Description? Add new test 'Shop parameters > Enable/Disable iframes'
Type? refacto
Category? TE
BC breaks? no
Deprecations? no
How to test? CI and nightly are 馃挌
UI Tests https://github.com/nesrineabdmouleh/testing_pr/actions/runs/6876418741
Fixed issue or discussion? no
Related PRs no
Sponsor company

@nesrineabdmouleh nesrineabdmouleh added TE Category: Tests E2E Tests labels Nov 15, 2023
@nesrineabdmouleh nesrineabdmouleh added this to the 9.0.0 milestone Nov 15, 2023
@prestonBot prestonBot added develop Branch Refactoring Type: Refactoring labels Nov 15, 2023
@nesrineabdmouleh nesrineabdmouleh marked this pull request as ready for review November 15, 2023 13:16
@nesrineabdmouleh nesrineabdmouleh requested a review from a team as a code owner November 15, 2023 13:16
Progi1984
Progi1984 previously approved these changes Nov 15, 2023
@boubkerbribri boubkerbribri added Waiting for author Status: action required, waiting for author feedback Waiting for rebase Status: action required, waiting for rebase labels Nov 16, 2023
@boubkerbribri
Copy link
Contributor

@nesrineabdmouleh please resolve conflicts

@nesrineabdmouleh nesrineabdmouleh removed Waiting for author Status: action required, waiting for author feedback Waiting for rebase Status: action required, waiting for rebase labels Nov 16, 2023
@nesrineabdmouleh nesrineabdmouleh added the QA 鉁旓笍 Status: check done, code approved label Nov 16, 2023
@nesrineabdmouleh nesrineabdmouleh merged commit a32b1f1 into PrestaShop:develop Nov 16, 2023
21 checks passed
@nesrineabdmouleh nesrineabdmouleh deleted the TEST-1045 branch November 24, 2023 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
develop Branch E2E Tests QA 鉁旓笍 Status: check done, code approved Refactoring Type: Refactoring TE Category: Tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants