Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix image legend not used #34689

Merged
merged 1 commit into from Nov 28, 2023
Merged

Fix image legend not used #34689

merged 1 commit into from Nov 28, 2023

Conversation

Hlavtox
Copy link
Contributor

@Hlavtox Hlavtox commented Nov 27, 2023 •
edited

Questions Answers
Branch? 8.1.x
Description? Product image legend was not used at all, if filled out. It was always overwritten by product name. I broke it here - #33387.
Type? bug fix
Category? FO
BC breaks? no
Deprecations? no
How to test? Prepare a product in BO with images WITH AND WITHOUT descriptions. Visit that product in FO, inspect the images and check that there is a product name OR the custom label in the title and alt tags. Test it with latest version of hummingbird.
UI Tests
Fixed issue or discussion? Fixes #33387 (comment)
Related PRs
Sponsor company

@Hlavtox Hlavtox requested a review from a team as a code owner November 27, 2023 09:19
@prestonBot prestonBot added 8.1.x Branch Bug fix Type: Bug fix labels Nov 27, 2023
@Hlavtox Hlavtox changed the base branch from develop to 8.1.x November 27, 2023 09:19
@PrestaShop PrestaShop deleted a comment from prestonBot Nov 27, 2023
@Hlavtox Hlavtox added this to the 8.1.3 milestone Nov 27, 2023
@Hlavtox Hlavtox closed this Nov 27, 2023
@Hlavtox Hlavtox reopened this Nov 27, 2023
@ShaiMagal ShaiMagal added the Waiting for QA Status: action required, waiting for test feedback label Nov 28, 2023
@florine2623 florine2623 self-assigned this Nov 28, 2023
florine2623
florine2623 approved these changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@florine2623 florine2623 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @Hlavtox ,

It is QA ✅

With description :
Screenshot 2023-11-28 at 16 39 21

Without description :
Screenshot 2023-11-28 at 16 39 14

alt and title are well displayed.

@florine2623 florine2623 added QA ✔️ Status: check done, code approved and removed Waiting for QA Status: action required, waiting for test feedback labels Nov 28, 2023
@Hlavtox Hlavtox merged commit a205a8e into PrestaShop:8.1.x Nov 28, 2023
56 checks passed
@StoreCommanderDev StoreCommanderDev mentioned this pull request Jan 17, 2024
Closed
@Hlavtox Hlavtox deleted the fix-empty-legend branch January 24, 2024 14:30
@Hlavtox Hlavtox mentioned this pull request Feb 23, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShaiMagal ShaiMagal ShaiMagal approved these changes

@florine2623 florine2623 florine2623 approved these changes

@boherm boherm boherm approved these changes

Assignees

@florine2623 florine2623

Labels
8.1.x Branch Bug fix Type: Bug fix QA ✔️ Status: check done, code approved
Projects
PR Dashboard
Archived in project
Milestone
8.1.3
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Hlavtox @ShaiMagal @florine2623 @boherm @prestonBot