Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove friendly url alert, put codes to columns #34738

Merged
merged 1 commit into from Dec 1, 2023
Merged

Remove friendly url alert, put codes to columns #34738

merged 1 commit into from Dec 1, 2023

Conversation

Hlavtox
Copy link
Contributor

@Hlavtox Hlavtox commented Nov 30, 2023 •
edited

Questions Answers
Branch? 8.1.x
Description? See below
Type? improvement
Category? BO
BC breaks? no
Deprecations? no
How to test? No need
UI Tests https://github.com/Hlavtox/ga.tests.ui.pr/actions/runs/7049341124
Fixed issue or discussion?
Related PRs
Sponsor company

Removed alert "Friendly URLs are enabled". They are enabled in 99.9% of cases, it only wastes space. Remain of the past.

friendlyurl

Product codes are now in columns instead of under each other. Saves 200px of vertical space.

codes

Already validated with @MatShir, putting PM ✅.

@Hlavtox Hlavtox requested a review from a team as a code owner November 30, 2023 14:57
@prestonBot prestonBot added 8.1.x Branch Improvement Type: Improvement labels Nov 30, 2023
@Hlavtox Hlavtox changed the base branch from develop to 8.1.x November 30, 2023 14:58
@Hlavtox Hlavtox added the PM ✔️ Status: check done, behavior approved label Nov 30, 2023
@Hlavtox Hlavtox added this to the 8.1.3 milestone Nov 30, 2023
@ps-jarvis ps-jarvis added the Waiting for QA Status: action required, waiting for test feedback label Nov 30, 2023
@Hlavtox Hlavtox closed this Nov 30, 2023
@Hlavtox Hlavtox reopened this Nov 30, 2023
@florine2623 florine2623 self-assigned this Dec 1, 2023
florine2623
florine2623 approved these changes Dec 1, 2023
View reviewed changes
Copy link
Contributor

@florine2623 florine2623 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @Hlavtox ,

LGTM.
It is QA ✅

Thanks!

@florine2623 florine2623 added QA ✔️ Status: check done, code approved and removed Waiting for QA Status: action required, waiting for test feedback labels Dec 1, 2023
@Hlavtox Hlavtox merged commit 1a1b04f into PrestaShop:8.1.x Dec 1, 2023
56 checks passed
@Hlavtox Hlavtox deleted the friendly-only-disabled branch January 24, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicosomb nicosomb nicosomb approved these changes

@mflasquin mflasquin mflasquin approved these changes

@ShaiMagal ShaiMagal ShaiMagal approved these changes

@florine2623 florine2623 florine2623 approved these changes

Assignees

@florine2623 florine2623

Labels
8.1.x Branch Improvement Type: Improvement PM ✔️ Status: check done, behavior approved QA ✔️ Status: check done, code approved
Projects
PR Dashboard
Archived in project
Milestone
8.1.3
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@Hlavtox @nicosomb @mflasquin @ShaiMagal @florine2623 @ps-jarvis @prestonBot