New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: fix sanity tests on workflow #34759
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
boubkerbribri
commented
Dec 4, 2023
Questions | Answers |
---|---|
Branch? | develop |
Description? | CI: fix sanity tests on workflow by adding URL_FO |
Type? | refacto |
Category? | TE |
BC breaks? | no |
Deprecations? | no |
How to test? | Sanity should be 馃煝 |
UI Tests | no changes to tests |
Fixed issue or discussion? | N/A |
Related PRs | N/A |
Sponsor company | PrestaShopCorp |
boubkerbribri
force-pushed
the
fix/sanity
branch
2 times, most recently
from
December 4, 2023 14:23
78c5033
to
8c62baa
Compare
boubkerbribri
changed the title
CI: fix sanity tests on workflow by adding URL_FO
CI: fix sanity tests on workflow
Dec 5, 2023
boubkerbribri
force-pushed
the
fix/sanity
branch
3 times, most recently
from
December 5, 2023 20:38
2b8277c
to
4d88b91
Compare
boubkerbribri
force-pushed
the
fix/sanity
branch
2 times, most recently
from
December 6, 2023 09:24
f036e2d
to
5447933
Compare
boubkerbribri
force-pushed
the
fix/sanity
branch
2 times, most recently
from
December 6, 2023 09:54
7444834
to
a8922bf
Compare
nesrineabdmouleh
previously approved these changes
Dec 6, 2023
boherm
previously approved these changes
Dec 6, 2023
QA approved, well done! Message to the maintainers: do not forget to milestone it before the merge. |
jolelievre
previously approved these changes
Dec 6, 2023
boubkerbribri
dismissed stale reviews from jolelievre, boherm, and nesrineabdmouleh
via
December 6, 2023 13:10
8fb95fc
boubkerbribri
force-pushed
the
fix/sanity
branch
from
December 6, 2023 13:10
a8922bf
to
8fb95fc
Compare
jolelievre
approved these changes
Dec 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @boubkerbribri
M0rgan01
approved these changes
Dec 6, 2023
nesrineabdmouleh
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
develop
Branch
E2E Tests
QA 鉁旓笍
Status: check done, code approved
Refactoring
Type: Refactoring
TE
Category: Tests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.