Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify sanity tests workflow to use docker #34773

Merged
merged 3 commits into from Dec 5, 2023
Merged

Modify sanity tests workflow to use docker #34773

merged 3 commits into from Dec 5, 2023

Conversation

jolelievre
Copy link
Contributor

@jolelievre jolelievre commented Dec 5, 2023 •
edited

Questions Answers
Branch? 8.1.x
Description? Modify sanity tests workflow to use docker instead of local apache environment, also remove the optimizations on product v2 campaign and force it to always run (the split didn't work as expected all the time)
Type? improvement
Category? TE
BC breaks? no
Deprecations? no
How to test? CI and UI tests green (but mostly CI)
UI Tests https://github.com/jolelievre/ga.tests.ui.pr/actions/runs/7104177725
Fixed issue or discussion? ~
Related PRs ~
Sponsor company ~

@prestonBot prestonBot added 8.1.x Branch Improvement Type: Improvement labels Dec 5, 2023
@jolelievre jolelievre marked this pull request as ready for review December 5, 2023 17:02
@jolelievre jolelievre requested a review from a team as a code owner December 5, 2023 17:02
@jolelievre jolelievre mentioned this pull request Dec 5, 2023
Closed
@ps-jarvis ps-jarvis added the Waiting for QA Status: action required, waiting for test feedback label Dec 5, 2023
@jolelievre jolelievre merged commit dbeb28e into PrestaShop:8.1.x Dec 5, 2023
38 checks passed
@jolelievre jolelievre deleted the sanity-with-docker branch December 5, 2023 21:12
@jolelievre jolelievre added this to the 8.1.3 milestone Dec 5, 2023
@jolelievre jolelievre removed the Waiting for QA Status: action required, waiting for test feedback label Dec 5, 2023
@matks matks mentioned this pull request Dec 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matks matks matks approved these changes

@boherm boherm boherm approved these changes

Assignees
No one assigned
Labels
8.1.x Branch Improvement Type: Improvement
Projects
PR Dashboard
Archived in project
Milestone
8.1.3
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jolelievre @matks @boherm @ps-jarvis @prestonBot