Add comments, remove unused constants #34927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Hlavtox
commented
Dec 28, 2023
•
Hlavtox
commented
| Questions | Answers |
|---|---|
| Branch? | develop |
| Description? | Removes some unused code related to smarty caching, some unused constants, adds some comments to debug mode and profiler. |
| Type? | refacto |
| Category? | CO |
| BC breaks? | yes |
| Deprecations? | no |
| How to test? | Tests green. |
| UI Tests | https://github.com/Hlavtox/ga.tests.ui.pr/actions/runs/7624051256 |
| Fixed issue or discussion? | |
| Related PRs | |
| Sponsor company |
Hlavtox
force-pushed
the
debug-mode-comments
branch
from
714b9b3
to
8285ec9
Compare
prestonBot
added
develop
Hlavtox
force-pushed
the
debug-mode-comments
branch
from
1ad1ba3
to
a253d05
Compare
|
@florine2623 Tests green 🟢 |
nicosomb
approved these changes
Jan 23, 2024
M0rgan01
approved these changes
Jan 24, 2024
ps-jarvis
added
the
Waiting for QA
|
Thanks @Hlavtox ! |
florine2623
added
QA ✔️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.