Backport newer method in filemanager #35006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Hlavtox
commented
Jan 9, 2024
•
Hlavtox
commented
| Questions | Answers |
|---|---|
| Branch? | 8.1.x |
| Description? | Backport newer version of method to get memory limit from https://github.com/trippo/ResponsiveFilemanager/blob/master/filemanager/include/utils.php. Will fix some issues with memory limit specified in different units then MB. |
| Type? | bug fix |
| Category? | BO |
| BC breaks? | no |
| Deprecations? | no |
| How to test? | Tests green. Try to go edit some CMS page, open file manager in the content field, see if it works normally. |
| UI Tests | https://github.com/Hlavtox/ga.tests.ui.pr/actions/runs/7654856344 |
| Fixed issue or discussion? | Fixes #35005 |
| Related PRs | |
| Sponsor company |
tleon
previously approved these changes
Jan 15, 2024
M0rgan01
previously approved these changes
Jan 16, 2024
ps-jarvis
added
the
Waiting for QA
florine2623
reviewed
Jan 25, 2024
There was a problem hiding this comment.
Hello @Hlavtox ,
Could you relaunch the failed test please ?
Also I have a warning when I try to import files via the File Manager and I can't import any files :
Screen.Recording.2024-01-25.at.15.28.46.mov
Could you check ? ^^
florine2623
added
the
Waiting for author
Hlavtox
force-pushed
the
fix-memory-limit
branch
from
2faf7fd
to
df59d5b
Compare
|
@florine2623 Could you try again now? :-) |
Hlavtox
removed
the
Waiting for author
|
LGTM @Hlavtox :) |
florine2623
added
QA ✔️
kpodemski
approved these changes
Jan 30, 2024
ShaiMagal
approved these changes
Jan 30, 2024
ps-jarvis
added
the
Waiting for QA
2 tasks
kpodemski
removed
the
Waiting for QA
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.