Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix and comment address deletion process #35017

Merged
merged 2 commits into from Jan 22, 2024
Merged

Fix and comment address deletion process #35017

merged 2 commits into from Jan 22, 2024

Conversation

Hlavtox
Copy link
Contributor

@Hlavtox Hlavtox commented Jan 10, 2024 •
edited by florine2623

Questions Answers
Branch? 8.1.x
Description? Resolves issues with deleting an address. Adds comments to make this process more clear.
Type? bug fix
Category? FO
BC breaks? no
Deprecations? no
How to test? Tests green, manual test. I would like @florine2623 to do the test. 🙏
UI Tests https://github.com/florine2623/testing_pr/actions/runs/7608395195
Fixed issue or discussion? Fixes #34059, Fixes #30350
Related PRs
Sponsor company

Previous PRs and authors

@Hlavtox Hlavtox requested a review from a team as a code owner January 10, 2024 13:42
@Hlavtox Hlavtox added this to the 8.1.4 milestone Jan 10, 2024
@prestonBot prestonBot added 8.1.x Branch Bug fix Type: Bug fix labels Jan 10, 2024
@PrestaShop PrestaShop deleted a comment from prestonBot Jan 10, 2024
@ps-jarvis ps-jarvis added the Waiting for QA Status: action required, waiting for test feedback label Jan 15, 2024
@florine2623 florine2623 self-assigned this Jan 22, 2024
florine2623
florine2623 approved these changes Jan 22, 2024
View reviewed changes
Copy link
Contributor

@florine2623 florine2623 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @Hlavtox ,

Auto tests OK ✅

Tested and followed steps from #34059 and #30350.
It works as expected, I still has access to my carriers and I can continue to checkout.

  • Tested the deletion of addresses from the BO as a merchant
  • Tested the addition of addresses from the customer in FO, in checkout process I tested having different addresses for billing address and shipping address.
  • Tested as guest and customer
  • Tested with a customer who already has multiple addresses, deleted just one address, deleted all of their addresses
Screen.Recording.2024-01-22.at.10.01.52.mov

LGTM

It is QA ✅

@florine2623 florine2623 added QA ✔️ Status: check done, code approved and removed Waiting for QA Status: action required, waiting for test feedback labels Jan 22, 2024
@boherm boherm merged commit 5369659 into PrestaShop:8.1.x Jan 22, 2024
38 checks passed
This was referenced Jan 22, 2024
Closed
Closed
Closed
@Hlavtox Hlavtox deleted the fix-address-deletion branch January 24, 2024 14:31
This was referenced Feb 28, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthieu-rolland matthieu-rolland matthieu-rolland approved these changes

@tleon tleon tleon approved these changes

@florine2623 florine2623 florine2623 approved these changes

@boherm boherm boherm approved these changes

@M0rgan01 M0rgan01 M0rgan01 approved these changes

Assignees

@florine2623 florine2623

Labels
8.1.x Branch Bug fix Type: Bug fix QA ✔️ Status: check done, code approved
Projects
PR Dashboard
Archived in project
Milestone
8.1.5
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@Hlavtox @matthieu-rolland @tleon @florine2623 @boherm @M0rgan01 @ps-jarvis @prestonBot