Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated PrestaShop Packages #35042

Merged
merged 1 commit into from Jan 17, 2024
Merged

Conversation

github-actions[bot]
Copy link

@github-actions github-actions bot commented Jan 12, 2024

Questions Answers
Branch? 8.1.x
Description? Updated PrestaShop composer packages, details below.
Type? Improvement
Category? co
BC breaks? no
Deprecations? no
Fixed ticket? N/A
How to tests N/A

Module prestashop/contactform: Bump version from v4.4.1 to v4.4.2
Module prestashop/ps_imageslider: Bump version from v3.1.3 to v3.1.4

@github-actions github-actions bot requested a review from a team as a code owner January 12, 2024 23:04
@prestonBot
Copy link
Collaborator

Hello @github-actions[bot]!

This is your first pull request on the PrestaShop project. Thank you, and welcome to this Open Source community!

@prestonBot
Copy link
Collaborator

Hi, thanks for this contribution!

I found some issues with the Pull Request description:

  • The category should be one of these: BO, CO, FO, IN, LO, ME, PM, TE or WS (Read explanation)

Would you mind having a look at it? This will help us understand how interesting your contribution is, thank you very much!

(Note: this is an automated message, but answering it will reach a real human)

@prestonBot prestonBot added the Improvement Type: Improvement label Jan 12, 2024
boherm
boherm previously approved these changes Jan 15, 2024
@M0rgan01 M0rgan01 added this to the 8.1.4 milestone Jan 15, 2024
M0rgan01
M0rgan01 previously approved these changes Jan 15, 2024
@ps-jarvis ps-jarvis added the Waiting for QA Status: action required, waiting for test feedback label Jan 15, 2024
@AureRita AureRita self-assigned this Jan 15, 2024
AureRita
AureRita previously approved these changes Jan 15, 2024
Copy link
Contributor

@AureRita AureRita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

I tested it and it seems to works as you can see :

image

Link to the auto test : https://github.com/AureRita/testing_pr/actions/runs/7530745955

Because the auto test is 🟢 and the PR seems to works as expected, It's QA ✔️

Thank you

@AureRita AureRita added QA ✔️ Status: check done, code approved and removed Waiting for QA Status: action required, waiting for test feedback labels Jan 15, 2024
@github-actions github-actions bot force-pushed the cron-php-update-modules-8.1.x branch from 902826d to 79044b6 Compare January 15, 2024 23:04
@github-actions github-actions bot dismissed stale reviews from AureRita, M0rgan01, and boherm via ebd2c2b January 16, 2024 23:07
@github-actions github-actions bot force-pushed the cron-php-update-modules-8.1.x branch from 79044b6 to ebd2c2b Compare January 16, 2024 23:07
@ps-jarvis ps-jarvis added the Waiting for QA Status: action required, waiting for test feedback label Jan 17, 2024
@matthieu-rolland matthieu-rolland merged commit 8d5e854 into 8.1.x Jan 17, 2024
@prestonBot prestonBot added the 8.1.x Branch label Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.1.x Branch Improvement Type: Improvement QA ✔️ Status: check done, code approved Waiting for QA Status: action required, waiting for test feedback
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

6 participants