Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix(dbdump): add complete insert in databasedump #35050

Merged
merged 1 commit into from Jan 16, 2024
Merged

Fix(dbdump): add complete insert in databasedump #35050

merged 1 commit into from Jan 16, 2024

Conversation

tleon
Copy link
Contributor

@tleon tleon commented Jan 16, 2024

Questions Answers
Branch? develop
Description? When running composer create-test-db sometimes, the inserts were exported in the dump with the wrong column order. This Fix ensure that the right value is inserted in the right column.
Type? bug fix
Category? TE
BC breaks? no
Deprecations? no
How to test? CI 馃煝
Sponsor company PrestaShop SA

@tleon tleon self-assigned this Jan 16, 2024
@tleon tleon requested a review from a team as a code owner January 16, 2024 10:46
@prestonBot prestonBot added develop Branch Bug fix Type: Bug fix labels Jan 16, 2024
jolelievre
jolelievre previously approved these changes Jan 16, 2024
View reviewed changes
Copy link
Contributor

@jolelievre jolelievre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tleon

M0rgan01
M0rgan01 previously approved these changes Jan 16, 2024
View reviewed changes
@M0rgan01 M0rgan01 added this to the 9.0.0 milestone Jan 16, 2024
@tleon tleon dismissed stale reviews from M0rgan01 and jolelievre via 4712734 January 16, 2024 10:55
@tleon tleon force-pushed the fix-database-dump-export branch 2 times, most recently from 4712734 to 7292216 Compare January 16, 2024 11:07
@matks matks changed the title fix(dbdump): add complete insert in databasedump Fix(dbdump): add complete insert in databasedump Jan 16, 2024
matks
matks approved these changes Jan 16, 2024
View reviewed changes
Copy link
Contributor

@matks matks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is green 馃帀

@tleon tleon mentioned this pull request Jan 16, 2024
Closed
2 tasks
@tleon tleon merged commit 7a95d3c into PrestaShop:develop Jan 16, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matks matks matks approved these changes

@jolelievre jolelievre jolelievre approved these changes

@M0rgan01 M0rgan01 M0rgan01 approved these changes

Assignees

@tleon tleon

Labels
Bug fix Type: Bug fix develop Branch
Projects
PR Dashboard
Archived in project
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@tleon @matks @jolelievre @M0rgan01 @prestonBot