Enable symfony layout feature flag by default

[jolelievre]

Questions	Answers
Branch?	develop
Description?
Type?	new feature
Category?	BO
BC breaks?	no
Deprecations?	no
How to test?	Ci green and UI tests green Symfony layout: https://github.com/jolelievre/ga.tests.ui.pr/actions/runs/7670270819 Legacy layout: https://github.com/jolelievre/ga.tests.ui.pr/actions/runs/7670297902
UI Tests
Fixed issue or discussion?	~
Related PRs	~
Sponsor company	~

[prestonBot]

Hi, thanks for this contribution!

I found some issues with the Pull Request description:

• The description shouldn't be empty.
• Your pull request does not seem to fix any issue, consider creating one (see note below) and linking it by writing Fixes #1234.

Would you mind having a look at it? This will help us understand how interesting your contribution is, thank you very much!

About linked issues

Please consider opening an issue before submitting a Pull Request:

• If it's a bug fix, it helps maintainers verify that the bug is effectively due to a defect in the code, and that it hasn't been fixed already.
• It can help trigger a discussion about the best implementation path before a single line of code is written.
• It may lead the Core Product team to mark that issue as a priority, further attracting the maintainers' attention.

(Note: this is an automated message, but answering it will reach a real human)

[Hlavtox]

There are some tiny issues:

Language code is encoded:

var full_language_code = 'en\u002Dus';
var full_cldr_language_code = 'en\u002Dus';

changeFormLanguageUrl missing, is it needed?

[jolelievre]

I just checked changeFormLanguageUrl is correctly injected in legacy pages (even with symfony layout) thanks to the setMedia that adds it I'm gonna remove the forced escape on the manual variables though

By the way changeFormLanguageUrl seems to be used only when PS_BO_ALLOW_EMPLOYEE_FORM_LANG is enabled in configuration, this configuration is not even the the default data anymore and it can't be edited either from the BO Seems like an old feature, only used on legacy pages

[Hlavtox]

@jolelievre I digged in and the feature is used. If you go to Advanced parameters >Employees and enable "Memorize the language used in Admin panel forms", it will enable PS_BO_ALLOW_EMPLOYEE_FORM_LANG. Anyway, good then.

So we fix the encoding and then it's ready. :-)

[jolelievre]

No QA for this one even though it enables the new symfony layout on the branch This will allow us to getearly feedback And a full manual QA is planned after we finish upgrading the remaining dependencies (removal of sensio framework extra bundle and upgrade of ApiPlatform)