Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean horizontal migration code #35191

Merged
merged 2 commits into from Jan 29, 2024

Conversation

jolelievre
Copy link
Contributor

@jolelievre jolelievre commented Jan 26, 2024

Questions Answers
Branch? develop
Description? Clean horizontal migration code
Type? refacto
Category? BO
BC breaks? yes
Deprecations? no
How to test? CI tests and UI tests green
UI Tests https://github.com/jolelievre/ga.tests.ui.pr/actions/runs/7671410854
Fixed issue or discussion? ~
Related PRs ~
Sponsor company ~

Breaking Change

All the classes related with the horizontal migration have been removed, but they were only here for an experiment and should not be used by anyone outside of the core so zero impact

@jolelievre jolelievre requested a review from a team as a code owner January 26, 2024 17:28
@prestonBot prestonBot added develop Branch Refactoring Type: Refactoring BC break Type: Introduces a backwards-incompatible break labels Jan 26, 2024
@ps-jarvis ps-jarvis added the Waiting for QA Status: action required, waiting for test feedback label Jan 28, 2024
@kpodemski kpodemski merged commit 6000722 into PrestaShop:develop Jan 29, 2024
23 checks passed
@kpodemski
Copy link
Contributor

thank you @jolelievre

@jolelievre jolelievre deleted the clean-horizontal-migration branch February 1, 2024 15:28
@kpodemski kpodemski removed the Waiting for QA Status: action required, waiting for test feedback label Feb 5, 2024
@kpodemski kpodemski added this to the 9.0.0 milestone Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BC break Type: Introduces a backwards-incompatible break develop Branch Refactoring Type: Refactoring
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

7 participants