Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix route name #35234

Merged
merged 1 commit into from Feb 1, 2024
Merged

Fix route name #35234

merged 1 commit into from Feb 1, 2024

Conversation

Hlavtox
Copy link
Contributor

@Hlavtox Hlavtox commented Feb 1, 2024 •
edited

Questions Answers
Branch? develop
Description? Fixes issue with forgotten old route name.
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
How to test? See related issue.
UI Tests https://github.com/Hlavtox/ga.tests.ui.pr/actions/runs/7738641235
Fixed issue or discussion? Fixes #35233
Related PRs
Sponsor company

@Hlavtox Hlavtox added this to the 9.0.0 milestone Feb 1, 2024
@Hlavtox Hlavtox requested a review from a team as a code owner February 1, 2024 08:56
@prestonBot prestonBot added develop Branch Bug fix Type: Bug fix labels Feb 1, 2024
@Hlavtox Hlavtox mentioned this pull request Feb 1, 2024
Closed
2 tasks
@PrestaShop PrestaShop deleted a comment from prestonBot Feb 1, 2024
@Hlavtox Hlavtox added the Waiting for QA Status: action required, waiting for test feedback label Feb 1, 2024
@florine2623 florine2623 self-assigned this Feb 1, 2024
florine2623
florine2623 approved these changes Feb 1, 2024
View reviewed changes
Copy link
Contributor

@florine2623 florine2623 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @Hlavtox 🚀

Thanks for the PR !

Screen.Recording.2024-02-01.at.14.37.21.mov

LGTM and QA ✅ !

@florine2623 florine2623 added QA ✔️ Status: check done, code approved and removed Waiting for QA Status: action required, waiting for test feedback labels Feb 1, 2024
@Hlavtox
Copy link
Contributor Author

Hlavtox commented Feb 1, 2024

Thank you @florine2623!

@Hlavtox Hlavtox merged commit 06853a4 into PrestaShop:develop Feb 1, 2024
23 checks passed
@jolelievre
Copy link
Contributor

Nice catch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicosomb nicosomb nicosomb approved these changes

@florine2623 florine2623 florine2623 approved these changes

@boherm boherm boherm approved these changes

Assignees

@florine2623 florine2623

Labels
Bug fix Type: Bug fix develop Branch QA ✔️ Status: check done, code approved
Projects
PR Dashboard
Archived in project
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.

BO - Customer page throws exception when the customer deletes his addresses from his shopping cart
6 participants
@Hlavtox @jolelievre @nicosomb @florine2623 @boherm @prestonBot