Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move debug and web profiler bundle into prod dependencies #35274

Merged
merged 1 commit into from Feb 6, 2024

Conversation

jolelievre
Copy link
Contributor

@jolelievre jolelievre commented Feb 6, 2024

Questions Answers
Branch? develop
Description? Move debug and web profiler bundle into dependencies instead of dev dependencies, they must be integrated with the prod dependencies so that Debug mode can be used with released built versions
Type? bug fix
Category? CO
BC breaks? no
Deprecations? no
How to test? CI green and UI tests green
UI Tests https://github.com/jolelievre/ga.tests.ui.pr/actions/runs/7797862129
Fixed issue or discussion? Partially fixes #35179
Related PRs ~
Sponsor company ~

…ependencies, they must be integrated with the prod dependencies so that Debug mode can be used with released built versions
@jolelievre jolelievre requested a review from a team as a code owner February 6, 2024 10:00
@prestonBot
Copy link
Collaborator

Hi, thanks for this contribution!

I found some issues with the Pull Request description:

  • Your pull request does not seem to fix any issue, consider creating one (see note below) and linking it by writing Fixes #1234.

Would you mind having a look at it? This will help us understand how interesting your contribution is, thank you very much!

About linked issues

Please consider opening an issue before submitting a Pull Request:

  • If it's a bug fix, it helps maintainers verify that the bug is effectively due to a defect in the code, and that it hasn't been fixed already.
  • It can help trigger a discussion about the best implementation path before a single line of code is written.
  • It may lead the Core Product team to mark that issue as a priority, further attracting the maintainers' attention.

(Note: this is an automated message, but answering it will reach a real human)

@prestonBot prestonBot added develop Branch Bug fix Type: Bug fix labels Feb 6, 2024
@jolelievre jolelievre changed the title Move debug and web profiler bundle into dependencies instead of dev d… Move debug and web profiler bundle into prod dependencies Feb 6, 2024
@ps-jarvis ps-jarvis added the Waiting for QA Status: action required, waiting for test feedback label Feb 6, 2024
@Progi1984 Progi1984 added this to the 9.0.0 milestone Feb 6, 2024
@jolelievre jolelievre removed the Waiting for QA Status: action required, waiting for test feedback label Feb 6, 2024
@jolelievre jolelievre merged commit 8c43a91 into PrestaShop:develop Feb 6, 2024
23 checks passed
@jolelievre jolelievre deleted the debug-bundle-in-release branch February 6, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug fix Type: Bug fix develop Branch
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Docker Nightly : White page (for the BackOffice)
6 participants