Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated ajaxDie method and deprecated hooks #35283

Merged
merged 1 commit into from
May 7, 2024
Merged

Remove deprecated ajaxDie method and deprecated hooks #35283

merged 1 commit into from
May 7, 2024

Conversation

Hlavtox
Copy link
Contributor

@Hlavtox Hlavtox commented Feb 7, 2024 •
edited

Questions Answers
Branch? develop
Description? Removed deprecated hooks and methods related to ajaxDie.
Type? refacto
Category? CO
BC breaks? yes
Deprecations? no
How to test? Tests green.
UI Tests https://github.com/Hlavtox/ga.tests.ui.pr/actions/runs/8984005226
Fixed issue or discussion?
Related PRs
Sponsor company

Related PRs

Removed methods and changes

classes/controller/Controller.php - removed ajaxDie method, removed calls to actionAjaxDieBefore and actionBeforeAjaxDie
classes/Hook.php - deleted removed hook actionAjaxDieBefore

Database changes required for upgraded installs

  • remove actionBeforeAjaxDie from hook and hook_alias
  • remove actionAjaxDieBefore from hook and hook_alias

@Hlavtox Hlavtox requested a review from a team as a code owner February 7, 2024 08:53
@prestonBot prestonBot added the develop Branch label Feb 7, 2024
@Hlavtox Hlavtox added this to the 9.0.0 milestone Feb 7, 2024
@prestonBot prestonBot added Refactoring Type: Refactoring BC break Type: Introduces a backwards-incompatible break labels Feb 7, 2024
This was referenced Feb 7, 2024
Merged
Merged
Merged
@kpodemski kpodemski added the Needs documentation Needs an update of the developer documentation label Feb 8, 2024
kpodemski
kpodemski previously approved these changes Feb 8, 2024
View reviewed changes
tleon
tleon previously approved these changes Feb 9, 2024
View reviewed changes
@Hlavtox Hlavtox added the Blocked Status: The issue is blocked by another task label Feb 9, 2024
@Hlavtox
Copy link
Contributor Author

Hlavtox commented Feb 9, 2024

Before we can continue to have green tests, we must first merge, release and updateincomposer the three related modules PR.

It fails on newsletter and themecusto. :-)

@Hlavtox Hlavtox removed the Blocked Status: The issue is blocked by another task label Apr 2, 2024
@Hlavtox Hlavtox added the Waiting for QA Status: action required, waiting for test feedback label Apr 9, 2024
FabienPapet
FabienPapet previously approved these changes Apr 10, 2024
View reviewed changes
@florine2623 florine2623 self-assigned this Apr 18, 2024
@florine2623
Copy link
Contributor

@Hlavtox , could you check the conflicts and fix them please ? 😄

Screenshot 2024-04-18 at 15 28 36

@florine2623 florine2623 added the Waiting for author Status: action required, waiting for author feedback label Apr 18, 2024
@Hlavtox Hlavtox dismissed stale reviews from FabienPapet, tleon, and kpodemski via c0e8cda April 25, 2024 10:23
@Hlavtox Hlavtox removed the Waiting for author Status: action required, waiting for author feedback label Apr 25, 2024
@Hlavtox
Copy link
Contributor Author

Hlavtox commented Apr 25, 2024

Rebased, can you reapprove please @FabienPapet @tleon @kpodemski 🙏

@Hlavtox
Copy link
Contributor Author

Hlavtox commented Apr 26, 2024

UI tests - https://github.com/Hlavtox/ga.tests.ui.pr/actions/runs/8844858941

@nicosomb
Copy link
Contributor

@Hlavtox UI tests are green, could you please relaunch them?

@nicosomb nicosomb added Waiting for author Status: action required, waiting for author feedback and removed Waiting for QA Status: action required, waiting for test feedback labels Apr 30, 2024
@Hlavtox Hlavtox force-pushed the remove-deprecated-ajaxdie branch from c0e8cda to 36b98c3 Compare May 7, 2024 10:45
@Hlavtox
Copy link
Contributor Author

Hlavtox commented May 7, 2024

Rebased, new tests - https://github.com/Hlavtox/ga.tests.ui.pr/actions/runs/8984005226

@prestashop-issue-bot prestashop-issue-bot bot removed the Waiting for author Status: action required, waiting for author feedback label May 7, 2024
@FabienPapet FabienPapet added the Waiting for QA Status: action required, waiting for test feedback label May 7, 2024
@Hlavtox
Copy link
Contributor Author

Hlavtox commented May 7, 2024

@nicosomb @kpodemski Tests finally green after rebase, can we merge? :-)

@kpodemski
Copy link
Contributor

Auto tests are ok, no need to test removal of the deprecated code.

@kpodemski kpodemski merged commit 54275fa into PrestaShop:develop May 7, 2024
35 checks passed
@kpodemski kpodemski removed the Waiting for QA Status: action required, waiting for test feedback label May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FabienPapet FabienPapet FabienPapet approved these changes

@ShaiMagal ShaiMagal ShaiMagal approved these changes

@tleon tleon Awaiting requested review from tleon

@kpodemski kpodemski Awaiting requested review from kpodemski

Assignees

@florine2623 florine2623

Labels
BC break Type: Introduces a backwards-incompatible break develop Branch Needs autoupgrade PR Needs documentation Needs an update of the developer documentation Refactoring Type: Refactoring
Projects
PR Dashboard
Archived in project
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@Hlavtox @florine2623 @nicosomb @kpodemski @FabienPapet @tleon @ShaiMagal @prestonBot