Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Functional tests - Fix 'FO:classic:01-03 get GDPR data in PDF' #35364

Merged

Conversation

nesrineabdmouleh
Copy link
Contributor

@nesrineabdmouleh nesrineabdmouleh commented Feb 14, 2024

Questions Answers
Branch? develop
Description? Fix 'FO:classic:01-03 get GDPR data in PDF'
Type? refacto
Category? TE
BC breaks? no
Deprecations? no
How to test? CI and nightly are 馃崗
UI Tests https://github.com/nesrineabdmouleh/testing_pr/actions/runs/7914012645
Fixed issue or discussion? no
Related PRs no
Sponsor company

@nesrineabdmouleh nesrineabdmouleh added TE Category: Tests E2E Tests labels Feb 14, 2024
@nesrineabdmouleh nesrineabdmouleh added this to the 9.0.0 milestone Feb 14, 2024
@prestonBot prestonBot added develop Branch Refactoring Type: Refactoring labels Feb 14, 2024
@nesrineabdmouleh nesrineabdmouleh marked this pull request as ready for review February 15, 2024 11:02
@nesrineabdmouleh nesrineabdmouleh requested a review from a team as a code owner February 15, 2024 11:02
tests/UI/approbo.txt Outdated Show resolved Hide resolved
Copy link
Contributor

@Progi1984 Progi1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A feedback (a file to remove)

Could you merge your commits ?

@nesrineabdmouleh nesrineabdmouleh added the QA 鉁旓笍 Status: check done, code approved label Feb 20, 2024
@nesrineabdmouleh nesrineabdmouleh merged commit ab196d3 into PrestaShop:develop Feb 20, 2024
26 checks passed
@nesrineabdmouleh nesrineabdmouleh deleted the fixNightly1402 branch February 20, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
develop Branch E2E Tests QA 鉁旓笍 Status: check done, code approved Refactoring Type: Refactoring TE Category: Tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants